-
Notifications
You must be signed in to change notification settings - Fork 698
Update prometheus metric exporter to comply with data model specification #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looking through the current implementation, it looks like the name is already sanitized. Unit suffixes are already added by the upstream library. TYPE metadata is already added by upstream as well. Remaining items (from the comment above):
|
I would like to take this issue. |
Hi, is there any update on the progress? We're running into some issue while exporting metrics to prometheus because they don't allow |
@dashpole since this is a breaking change to metric names, I'd like to minimize the disruption by fixing as much as possible at once. I see the spec also has But I don't see it in the Go impl. Should I be implementing this case as well? |
You can skip it if it isn't in other SDK implementations. |
But here is the collector's implementation of foo_per_bar: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/normalize_name.go |
I implemented the "per" conversion in this PR as well |
The exporter should perform this such as
Link to spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#otlp-metric-points-to-prometheus
The text was updated successfully, but these errors were encountered: