Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #4513

Open
xrmx opened this issue Mar 27, 2025 · 4 comments · May be fixed by #4520 or open-telemetry/opentelemetry-python-contrib#3399
Open

Drop support for Python 3.8 #4513

xrmx opened this issue Mar 27, 2025 · 4 comments · May be fixed by #4520 or open-telemetry/opentelemetry-python-contrib#3399
Labels
feature-request

Comments

@xrmx
Copy link
Contributor

xrmx commented Mar 27, 2025 •
edited
Loading

Python 3.8 has been EOL'ed in 2024-10-07 which is near the end of our 6 months support promise.
So we can think of dropping it and save some CI time.

We have a checklist of things to do in CONTRIBUTING when bumping our baseline.

Double check that list and update it if needed (does ruff have a baseline too?). Also maybe take a look at pyupgrade to handle any python feature we can now leverage.

Also we can bump the pypy version to something more modern like 7.3.16.

This also require changes in -contrib.
@xrmx
Copy link
Contributor Author

xrmx commented Mar 27, 2025 •
edited
Loading

From a quick grep we can cleanup these checks:

opentelemetry-sdk/tests/metrics/exponential_histogram/test_exponent_mapping.py:if version_info >= (3, 9):
opentelemetry-sdk/tests/metrics/exponential_histogram/test_exponent_mapping.py:        version_info < (3, 9),

More wins in -contrib

@jomcgi
Copy link
Contributor

jomcgi commented Mar 27, 2025

Hey! is this available for me to pickup?
It sounds like a good opportunity to get more familiar with the codebase.

@emdneto
Copy link
Member

emdneto commented Mar 28, 2025 •
edited
Loading

@jomcgi Code reviews are also very welcome and a good way to get used to the codebase 😅

@jomcgi
Copy link
Contributor

jomcgi commented Mar 28, 2025

Agreed - I'll start reviewing PRs.
Also still happy to pick up this task

This was referenced Mar 31, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
3 participants
@xrmx @emdneto @jomcgi