From c108ff35c0b64e98552d65e14d0453f849501b5b Mon Sep 17 00:00:00 2001 From: Howard Yoo <32691630+howardyoo@users.noreply.github.com> Date: Sat, 9 Mar 2024 22:45:32 -0600 Subject: [PATCH 1/3] Update ValueError message that is misleading Related issue: https://github.com/open-telemetry/opentelemetry-python/issues/3768 where error message does not include 'infinity' as one of the accepted range of values for interval. --- .../src/opentelemetry/sdk/metrics/_internal/export/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py index e7099562eb8..39e841ff2ea 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py @@ -496,7 +496,7 @@ def __init__( elif self._export_interval_millis <= 0: raise ValueError( f"interval value {self._export_interval_millis} is invalid \ - and needs to be larger than zero and lower than infinity." + and needs to be larger than zero and lower than or equal to infinity." ) def _at_fork_reinit(self): From 4271001e1fd80b5cc75c92a25a44245a278f4e10 Mon Sep 17 00:00:00 2001 From: Howard Yoo <32691630+howardyoo@users.noreply.github.com> Date: Sat, 9 Mar 2024 22:52:48 -0600 Subject: [PATCH 2/3] Update CHANGELOG.md added to changelog.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f9d6613214..50e6f2125d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ([#3751](https://github.com/open-telemetry/opentelemetry-python/pull/3751)) - bump mypy to 0.982 ([#3776](https://github.com/open-telemetry/opentelemetry-python/pull/3776)) +- Fix ValueError message for PeriodicExportingMetricsReader + ([#3769](https://github.com/open-telemetry/opentelemetry-python/pull/3769)) ## Version 1.23.0/0.44b0 (2024-02-23) From 5dd7327102da096618805490e1c91b1c14cf5831 Mon Sep 17 00:00:00 2001 From: Howard Yoo <32691630+howardyoo@users.noreply.github.com> Date: Tue, 12 Mar 2024 08:50:59 -0500 Subject: [PATCH 3/3] Update __init__.py fixed the sentence to be more concise. --- .../src/opentelemetry/sdk/metrics/_internal/export/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py index 39e841ff2ea..14546636a94 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py @@ -496,7 +496,7 @@ def __init__( elif self._export_interval_millis <= 0: raise ValueError( f"interval value {self._export_interval_millis} is invalid \ - and needs to be larger than zero and lower than or equal to infinity." + and needs to be larger than zero." ) def _at_fork_reinit(self):