Skip to content

Be able to specify the fee aside the amount to be transferred in Xtokens #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
girazoki opened this issue Nov 17, 2021 · 3 comments · Fixed by #658
Closed

Be able to specify the fee aside the amount to be transferred in Xtokens #655

girazoki opened this issue Nov 17, 2021 · 3 comments · Fixed by #658

Comments

@girazoki
Copy link
Contributor

This is a usecase we encountered in Moonbeam, where we need to specify the fee (the amount to be provided in BuyExecution) as a separate argument to the amount being transferred, with the goal of better controlling the amount received in the destination side. We are in the process of adding this to Xtokens in our own fork, would you be interested on having such feature too? I could do a PR with my changes if you are interested

@girazoki
Copy link
Contributor Author

Just FYI, I am making this changes as an additional functionality (by adding two new extrinsics), I am not changing any of the existing functionality in Xtokens

@xlc
Copy link
Member

xlc commented Nov 17, 2021

Happy to accept PR as long as it is transaction version compatible.

@girazoki
Copy link
Contributor Author

girazoki commented Nov 22, 2021

This is a first draft, let me know if this is something you would like to add #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants