misc fixes

Author: eli-bl

Diff for: .changeset/drop_support_for_python_38.md

@@ -0,0 +1,8 @@
+---
+default: major
+---
+
+# Drop support for Python 3.8
+
+Python 3.8 is no longer supported. "New" 3.9 syntax, like generics on builtin collections, is used both in the generator 
+and the generated code.

Diff for: .changeset/type_is_now_a_reserved_field_name.md

@@ -0,0 +1,8 @@
+---
+default: major
+---
+
+# `type` is now a reserved field name
+
+Because `type` is used in type annotations now, it is no longer a valid field name. Fields which were previously named 
+`type` will be renamed to `type_`.

Diff for: .github/workflows/checks.yml

@@ -131,7 +131,7 @@ jobs:
       - name: Set up Python
         uses: actions/[email protected]
         with:
-          python-version: "3.8"
+          python-version: "3.9"
       - name: Get Python Version
         id: get_python_version
         run: echo "python_version=$(python --version)" >> $GITHUB_OUTPUT

Diff for: .github/workflows/release.yml

@@ -18,6 +18,6 @@ jobs:
       - name: Build
         run: hatchling build
       - name: Push to PyPI
-        uses: pypa/gh-action-pypi-publish@v1.10.3
+        uses: pypa/gh-action-pypi-publish@v1.12.2
         with:
             attestations: true

Diff for: CHANGELOG.md

@@ -13,6 +13,13 @@ Programmatic usage of this project (e.g., importing it as a Python module) and t
 
 The 0.x prefix used in versions for this project is to indicate that breaking changes are expected frequently (several times a year). Breaking changes will increment the minor number, all other changes will increment the patch number. You can track the progress toward 1.0 [here](https://github.com/openapi-generators/openapi-python-client/projects/2).
 
+## 0.21.7 (2024-10-28)
+
+### Fixes
+
+- allow required fields list to be specified as empty (#651) (#1149)
+- import cast for required const properties, since it's used in the template (#1153)
+
 ## 0.21.6 (2024-10-20)
 
 ### Features

Diff for: CONTRIBUTING.md

@@ -41,7 +41,7 @@ To request a feature:
 ### Setting up a Dev Environment
 
 1. Make sure you have [PDM](https://pdm-project.org) installed and up to date.
-2. Make sure you have a supported Python version (e.g. 3.8) installed.
+2. Make sure you have a supported Python version (e.g. 3.13) installed.
 3. Use `pdm install` in the project directory to create a virtual environment with the relevant dependencies.
 
 ### Writing tests

Diff for: end_to_end_tests/custom-templates-golden-record/my_test_api_client/api/__init__.py

@@ -1,7 +1,5 @@
 """Contains methods for accessing the API"""
 
-from typing import Type
-
 from .bodies import BodiesEndpoints
 from .config import ConfigEndpoints
 from .default import DefaultEndpoints
@@ -19,53 +17,53 @@
 
 class MyTestApiClientApi:
     @classmethod
-    def bodies(cls) -> Type[BodiesEndpoints]:
+    def bodies(cls) -> type[BodiesEndpoints]:
         return BodiesEndpoints
 
     @classmethod
-    def tests(cls) -> Type[TestsEndpoints]:
+    def tests(cls) -> type[TestsEndpoints]:
         return TestsEndpoints
 
     @classmethod
-    def defaults(cls) -> Type[DefaultsEndpoints]:
+    def defaults(cls) -> type[DefaultsEndpoints]:
         return DefaultsEndpoints
 
     @classmethod
-    def enums(cls) -> Type[EnumsEndpoints]:
+    def enums(cls) -> type[EnumsEndpoints]:
         return EnumsEndpoints
 
     @classmethod
-    def responses(cls) -> Type[ResponsesEndpoints]:
+    def responses(cls) -> type[ResponsesEndpoints]:
         return ResponsesEndpoints
 
     @classmethod
-    def default(cls) -> Type[DefaultEndpoints]:
+    def default(cls) -> type[DefaultEndpoints]:
         return DefaultEndpoints
 
     @classmethod
-    def parameters(cls) -> Type[ParametersEndpoints]:
+    def parameters(cls) -> type[ParametersEndpoints]:
         return ParametersEndpoints
 
     @classmethod
-    def tag1(cls) -> Type[Tag1Endpoints]:
+    def tag1(cls) -> type[Tag1Endpoints]:
         return Tag1Endpoints
 
     @classmethod
-    def location(cls) -> Type[LocationEndpoints]:
+    def location(cls) -> type[LocationEndpoints]:
         return LocationEndpoints
 
     @classmethod
-    def true_(cls) -> Type[True_Endpoints]:
+    def true_(cls) -> type[True_Endpoints]:
         return True_Endpoints
 
     @classmethod
-    def naming(cls) -> Type[NamingEndpoints]:
+    def naming(cls) -> type[NamingEndpoints]:
         return NamingEndpoints
 
     @classmethod
-    def parameter_references(cls) -> Type[ParameterReferencesEndpoints]:
+    def parameter_references(cls) -> type[ParameterReferencesEndpoints]:
         return ParameterReferencesEndpoints
 
     @classmethod
-    def config(cls) -> Type[ConfigEndpoints]:
+    def config(cls) -> type[ConfigEndpoints]:
         return ConfigEndpoints

Diff for: end_to_end_tests/functional_tests/generated_code_execution/test_arrays.py

@@ -1,4 +1,4 @@
-from typing import Any, ForwardRef, List, Union
+from typing import Any, ForwardRef, Union
 
 from end_to_end_tests.functional_tests.helpers import (
     assert_model_decode_encode,
@@ -65,9 +65,9 @@ def test_array_of_object(self, ModelWithArrayOfObjects, SimpleObject):
         )
 
     def test_type_hints(self, ModelWithArrayOfAny, ModelWithArrayOfInts, ModelWithArrayOfObjects, Unset):
-        assert_model_property_type_hint(ModelWithArrayOfAny, "array_prop", Union[List[Any], Unset])
-        assert_model_property_type_hint(ModelWithArrayOfInts, "array_prop", Union[List[int], Unset])
-        assert_model_property_type_hint(ModelWithArrayOfObjects, "array_prop", Union[List[ForwardRef("SimpleObject")], Unset])
+        assert_model_property_type_hint(ModelWithArrayOfAny, "array_prop", Union[list[Any], Unset])
+        assert_model_property_type_hint(ModelWithArrayOfInts, "array_prop", Union[list[int], Unset])
+        assert_model_property_type_hint(ModelWithArrayOfObjects, "array_prop", Union[list["SimpleObject"], Unset])
 
 
 @with_generated_client_fixture(
@@ -133,16 +133,16 @@ def test_prefix_items_and_regular_items(self, ModelWithMixedItems, SimpleObject)
         )
 
     def test_type_hints(self, ModelWithSinglePrefixItem, ModelWithPrefixItems, ModelWithMixedItems, Unset):
-        assert_model_property_type_hint(ModelWithSinglePrefixItem, "array_prop", Union[List[str], Unset])
+        assert_model_property_type_hint(ModelWithSinglePrefixItem, "array_prop", Union[list[str], Unset])
         assert_model_property_type_hint(
             ModelWithPrefixItems,
             "array_prop",
-            Union[List[Union[ForwardRef("SimpleObject"), str]], Unset],
+            Union[list[Union[ForwardRef("SimpleObject"), str]], Unset],
         )
         assert_model_property_type_hint(
             ModelWithMixedItems,
             "array_prop",
-            Union[List[Union[ForwardRef("SimpleObject"), str]], Unset],
+            Union[list[Union[ForwardRef("SimpleObject"), str]], Unset],
         )
         # Note, this test is asserting the current behavior which, due to limitations of the implementation
         # (see: https://github.com/openapi-generators/openapi-python-client/pull/1130), is not really doing

Diff for: end_to_end_tests/functional_tests/generated_code_execution/test_docstrings.py

@@ -1,4 +1,4 @@
-from typing import Any, List
+from typing import Any
 
 from end_to_end_tests.functional_tests.helpers import (
     with_generated_code_import,
@@ -7,12 +7,12 @@
 
 
 class DocstringParser:
-    lines: List[str]
+    lines: list[str]
 
     def __init__(self, item: Any):
         self.lines = [line.lstrip() for line in item.__doc__.split("\n")]
 
-    def get_section(self, header_line: str) -> List[str]:
+    def get_section(self, header_line: str) -> list[str]:
         lines = self.lines[self.lines.index(header_line)+1:]
         return lines[0:lines.index("")]
 

Diff for: end_to_end_tests/functional_tests/helpers.py

@@ -1,6 +1,6 @@
 from typing import Any, Dict
 import re
-from typing import List, Optional
+from typing import Optional
 
 from click.testing import Result
 import pytest
@@ -12,7 +12,7 @@ def with_generated_client_fixture(
     openapi_spec: str,
     name: str="generated_client",
     config: str="",
-    extra_args: List[str] = [],
+    extra_args: list[str] = [],
 ):
     """Decorator to apply to a test class to create a fixture inside it called 'generated_client'.
     
@@ -79,7 +79,7 @@ def assert_model_property_type_hint(model_class: Any, name: str, expected_type_h
 
 def inline_spec_should_fail(
     openapi_spec: str,
-    extra_args: List[str] = [],
+    extra_args: list[str] = [],
     config: str = "",
     filename_suffix: str = "",
     add_missing_sections = True,
@@ -122,7 +122,7 @@ def __init__(self, generated_client: GeneratedClientContext) -> None:
         assert "Warning(s) encountered while generating" in output
         self.by_schema = {}
         self.output = output
-        bad_schema_regex = "Unable to (parse|process) schema /components/schemas/(\w*)"
+        bad_schema_regex = "Unable to (parse|process) schema /components/schemas/(\\w*)"
         last_name = ""
         while True:
             if not (match := re.search(bad_schema_regex, output)):

Diff for: end_to_end_tests/generated_client.py

@@ -5,7 +5,7 @@
 from pathlib import Path
 import sys
 import tempfile
-from typing import Any, List, Optional, Set
+from typing import Any, Optional
 
 from attrs import define
 import pytest
@@ -28,7 +28,7 @@ class GeneratedClientContext:
     generator_result: Result
     base_module: str
     monkeypatch: pytest.MonkeyPatch
-    old_modules: Optional[Set[str]] = None
+    old_modules: Optional[set[str]] = None
 
     def __enter__(self) -> "GeneratedClientContext":
         self.monkeypatch.syspath_prepend(self.output_path)
@@ -59,7 +59,7 @@ def import_symbol(self, module_path: str, name: str) -> Any:
 
 def _run_command(
     command: str,
-    extra_args: Optional[List[str]] = None,
+    extra_args: Optional[list[str]] = None,
     openapi_document: Optional[str] = None,
     url: Optional[str] = None,
     config_path: Optional[Path] = None,
@@ -85,7 +85,7 @@ def _run_command(
 
 def generate_client(
     openapi_document: str,
-    extra_args: List[str] = [],
+    extra_args: list[str] = [],
     output_path: str = "my-test-api-client",
     base_module: str = "my_test_api_client",
     specify_output_path_explicitly: bool = True,
@@ -112,7 +112,7 @@ def generate_client(
 
 def generate_client_from_inline_spec(
     openapi_spec: str,
-    extra_args: List[str] = [],
+    extra_args: list[str] = [],
     config: str = "",
     filename_suffix: Optional[str] = None,
     base_module: str = "testapi_client",

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/bodies/json_like.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union
+from typing import Any, Optional, Union
 
 import httpx
 
@@ -12,10 +12,10 @@
 def _get_kwargs(
     *,
     body: JsonLikeBody,
-) -> Dict[str, Any]:
-    headers: Dict[str, Any] = {}
+) -> dict[str, Any]:
+    headers: dict[str, Any] = {}
 
-    _kwargs: Dict[str, Any] = {
+    _kwargs: dict[str, Any] = {
         "method": "post",
         "url": "/bodies/json-like",
     }

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/bodies/post_bodies_multiple.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union
+from typing import Any, Optional, Union
 
 import httpx
 
@@ -19,10 +19,10 @@ def _get_kwargs(
         PostBodiesMultipleDataBody,
         PostBodiesMultipleFilesBody,
     ],
-) -> Dict[str, Any]:
-    headers: Dict[str, Any] = {}
+) -> dict[str, Any]:
+    headers: dict[str, Any] = {}
 
-    _kwargs: Dict[str, Any] = {
+    _kwargs: dict[str, Any] = {
         "method": "post",
         "url": "/bodies/multiple",
     }

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/bodies/refs.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union
+from typing import Any, Optional, Union
 
 import httpx
 
@@ -12,10 +12,10 @@
 def _get_kwargs(
     *,
     body: AModel,
-) -> Dict[str, Any]:
-    headers: Dict[str, Any] = {}
+) -> dict[str, Any]:
+    headers: dict[str, Any] = {}
 
-    _kwargs: Dict[str, Any] = {
+    _kwargs: dict[str, Any] = {
         "method": "post",
         "url": "/bodies/refs",
     }

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/config/content_type_override.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union, cast
+from typing import Any, Optional, Union, cast
 
 import httpx
 
@@ -11,10 +11,10 @@
 def _get_kwargs(
     *,
     body: str,
-) -> Dict[str, Any]:
-    headers: Dict[str, Any] = {}
+) -> dict[str, Any]:
+    headers: dict[str, Any] = {}
 
-    _kwargs: Dict[str, Any] = {
+    _kwargs: dict[str, Any] = {
         "method": "post",
         "url": "/config/content-type-override",
     }

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/default/get_common_parameters.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union
+from typing import Any, Optional, Union
 
 import httpx
 
@@ -11,14 +11,14 @@
 def _get_kwargs(
     *,
     common: Union[Unset, str] = UNSET,
-) -> Dict[str, Any]:
-    params: Dict[str, Any] = {}
+) -> dict[str, Any]:
+    params: dict[str, Any] = {}
 
     params["common"] = common
 
     params = {k: v for k, v in params.items() if v is not UNSET and v is not None}
 
-    _kwargs: Dict[str, Any] = {
+    _kwargs: dict[str, Any] = {
         "method": "get",
         "url": "/common_parameters",
         "params": params,

Diff for: end_to_end_tests/golden-record/my_test_api_client/api/default/get_models_allof.py

@@ -1,5 +1,5 @@
 from http import HTTPStatus
-from typing import Any, Dict, Optional, Union
+from typing import Any, Optional, Union
 
 import httpx
 
@@ -9,8 +9,8 @@
 from ...types import Response
 
 
-def _get_kwargs() -> Dict[str, Any]:
-    _kwargs: Dict[str, Any] = {
+def _get_kwargs() -> dict[str, Any]:
+    _kwargs: dict[str, Any] = {
         "method": "get",
         "url": "/models/allof",
     }