Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Tell openapi-python-client update to not change certain folders/packages #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adelevie opened this issue Jun 29, 2022 · 4 comments
Closed
Labels
✨ enhancement New feature or improvement

Comments

@adelevie
Copy link
Contributor

When I run:

openapi-python-client update --path apispec.yaml 

A custom folder, util is deleted.

I'd like to have an option where update will ignore the util folder.

I've considered somehow bundling the util folder outside of the package, but I really want something where it's straightforward to distribute some higher level code built on top of the really nice generated code.

@adelevie adelevie added the ✨ enhancement New feature or improvement label Jun 29, 2022
@adelevie
Copy link
Contributor Author

Looks like this line could be replaced https://github.com/openapi-generators/openapi-python-client/blob/main/openapi_python_client/__init__.py#L130 with something that either:

  1. explicitly only deletes known folder names (e.g. only models and only api), OR

  2. deletes everything except some allow-listed folder names

@adelevie
Copy link
Contributor Author

here's a short proof of concept:

#641

@dbanty
Copy link
Collaborator

dbanty commented Jul 2, 2022

Related to #454 I think

@adelevie
Copy link
Contributor Author

adelevie commented Jul 2, 2022

Absolutely related, thanks for pointing out.

Happy to try and take my proof concept across the finish line, but also not sure what the desired developer experience is.

I do like the "ignore" terminology in #454, for what it's worth.

@openapi-generators openapi-generators locked and limited conversation to collaborators Aug 13, 2023
@dbanty dbanty converted this issue into discussion #812 Aug 13, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants