Micro perf improvement

Author: drwpow

packages/openapi-fetch/src/index.js

@@ -3,7 +3,6 @@ const DEFAULT_HEADERS = {
   "Content-Type": "application/json",
 };
 
-const LEADING_QUESTION_RE = /^\?+/;
 const PATH_PARAM_RE = /\{[^{}]+\}/g;
 
 /**
@@ -19,7 +18,7 @@ export default function createClient(clientOptions) {
   } = clientOptions ?? {};
   let baseUrl = baseOptions.baseUrl ?? "";
   if (baseUrl.endsWith("/")) {
-    baseUrl = baseUrl.slice(0, -1); // remove trailing slash
+    baseUrl = baseUrl.substring(0, baseUrl.length - 1);
   }
 
   /**
@@ -331,12 +330,8 @@ export function createQuerySerializer(options) {
  * @see https://swagger.io/docs/specification/serialization/#path
  */
 export function defaultPathSerializer(pathname, pathParams) {
-  const matches = pathname.match(PATH_PARAM_RE);
-  if (!matches || !matches.length) {
-    return undefined;
-  }
   let nextURL = pathname;
-  for (const match of matches) {
+  for (const match of pathname.match(PATH_PARAM_RE) ?? []) {
     let paramName = match.substring(1, match.length - 1);
     let explode = false;
     let style = "simple";
@@ -411,9 +406,10 @@ export function createFinalURL(pathname, options) {
   if (options.params?.path) {
     finalURL = defaultPathSerializer(finalURL, options.params.path);
   }
-  const search = options
-    .querySerializer(options.params.query ?? {})
-    .replace(LEADING_QUESTION_RE, "");
+  let search = options.querySerializer(options.params.query ?? {});
+  if (search.startsWith("?")) {
+    search = search.substring(1);
+  }
   if (search) {
     finalURL += `?${search}`;
   }