Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Commit 9c9ad04

Browse files
committed
use from xarray.ufuncs import isnan, isinf
1 parent 581c380 commit 9c9ad04

File tree

6 files changed

+20
-17
lines changed

6 files changed

+20
-17
lines changed

nowcasting_dataset/data_sources/gsp/gsp_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
""" Model for output of GSP data """
22
import logging
3-
import numpy as np
3+
from xarray.ufuncs import isnan, isinf
44

55
from nowcasting_dataset.data_sources.datasource_output import (
66
DataSourceOutput,
@@ -19,8 +19,8 @@ class GSP(DataSourceOutput):
1919
@classmethod
2020
def model_validation(cls, v):
2121
""" Check that all values are non NaNs """
22-
assert (~np.isnan(v.data)).all(), f"Some gsp data values are NaNs"
23-
assert (~np.isinf(v.data)).all(), f"Some gsp data values are Infinite"
22+
assert (~isnan(v.data)).all(), f"Some gsp data values are NaNs"
23+
assert (~isinf(v.data)).all(), f"Some gsp data values are Infinite"
2424
assert (v.data >= 0).all(), f"Some gsp data values are below 0 {v.data.min()}"
2525

2626
return v

nowcasting_dataset/data_sources/nwp/nwp_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import logging
55

6-
import numpy as np
6+
from xarray.ufuncs import isnan, isinf
77

88
from nowcasting_dataset.data_sources.datasource_output import (
99
DataSourceOutput,
@@ -24,6 +24,6 @@ class NWP(DataSourceOutput):
2424
@classmethod
2525
def model_validation(cls, v):
2626
""" Check that all values are not NaNs """
27-
assert (~np.isnan(v.data)).all(), "Some nwp data values are NaNs"
28-
assert (~np.isinf(v.data)).all(), f"Some nwp data values are Infinite"
27+
assert (~isnan(v.data)).all(), "Some nwp data values are NaNs"
28+
assert (~isinf(v.data)).all(), f"Some nwp data values are Infinite"
2929
return v

nowcasting_dataset/data_sources/pv/pv_model.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import logging
33

44
import numpy as np
5+
from xarray.ufuncs import isnan, isinf
56
from pydantic import Field, validator
67

78
from nowcasting_dataset.consts import (
@@ -32,8 +33,8 @@ class PV(DataSourceOutput):
3233
@classmethod
3334
def model_validation(cls, v):
3435
""" Check that all values are non NaNs """
35-
assert (~np.isnan(v.data)).all(), f"Some pv data values are NaNs"
36-
assert (v.data != np.Inf).all(), f"Some pv data values are Infinite"
36+
assert (~isnan(v.data)).all(), f"Some pv data values are NaNs"
37+
assert (~isinf(v.data)).all(), f"Some pv data values are Infinite"
3738

3839
assert (v.data >= 0).all(), f"Some pv data values are below 0"
3940

nowcasting_dataset/data_sources/satellite/satellite_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import logging
55

66
import numpy as np
7-
import xarray as xr
7+
from xarray.ufuncs import isnan, isinf
88
from pydantic import Field
99

1010
from nowcasting_dataset.consts import Array
@@ -27,7 +27,7 @@ class Satellite(DataSourceOutput):
2727
@classmethod
2828
def model_validation(cls, v):
2929
""" Check that all values are non negative """
30-
assert (~np.isnan(v.data)).all(), f"Some satellite data values are NaNs"
31-
assert (~np.isinf(v.data)).all(), f"Some satellite data values are Infinite"
30+
assert (~isnan(v.data)).all(), f"Some satellite data values are NaNs"
31+
assert (~isinf(v.data)).all(), f"Some satellite data values are Infinite"
3232
assert (v.data != -1).all(), f"Some satellite data values are -1's"
3333
return v

nowcasting_dataset/data_sources/sun/sun_model.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import logging
33

44
import numpy as np
5+
from xarray.ufuncs import isnan, isinf
56
from pydantic import Field, validator
67

78
from nowcasting_dataset.consts import Array, SUN_AZIMUTH_ANGLE, SUN_ELEVATION_ANGLE
@@ -23,11 +24,11 @@ class Sun(DataSourceOutput):
2324
@classmethod
2425
def model_validation(cls, v):
2526
""" Check that all values are non NaNs """
26-
assert (~np.isnan(v.elevation)).all(), f"Some elevation data values are NaNs"
27-
assert (~np.isinf(v.elevation)).all(), f"Some elevation data values are Infinite"
27+
assert (~isnan(v.elevation)).all(), f"Some elevation data values are NaNs"
28+
assert (~isinf(v.elevation)).all(), f"Some elevation data values are Infinite"
2829

29-
assert (~np.isnan(v.azimuth)).all(), f"Some azimuth data values are NaNs"
30-
assert (~np.isinf(v.azimuth)).all(), f"Some azimuth data values are Infinite"
30+
assert (~isnan(v.azimuth)).all(), f"Some azimuth data values are NaNs"
31+
assert (~isinf(v.azimuth)).all(), f"Some azimuth data values are Infinite"
3132

3233
assert (0 <= v.azimuth).all(), f"Some azimuth data values are lower 0, {v.azimuth.min()}"
3334
assert (

nowcasting_dataset/data_sources/topographic/topographic_model.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import logging
33

44
import numpy as np
5+
from xarray.ufuncs import isnan, isinf
56
from pydantic import Field, validator
67

78
from nowcasting_dataset.consts import Array
@@ -21,6 +22,6 @@ class Topographic(DataSourceOutput):
2122
@classmethod
2223
def model_validation(cls, v):
2324
""" Check that all values are non NaNs """
24-
assert (~np.isnan(v.data)).all(), f"Some topological data values are NaNs"
25-
assert (~np.isinf(v.data)).all(), f"Some topological data values are Infinite"
25+
assert (~isnan(v.data)).all(), f"Some topological data values are NaNs"
26+
assert (~isinf(v.data)).all(), f"Some topological data values are Infinite"
2627
return v

0 commit comments

Comments
 (0)