Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Commit dad3d2f

Browse files
Apply suggestions from code review
PR comments from Jack - thanks Co-authored-by: Jack Kelly <[email protected]>
1 parent 5649454 commit dad3d2f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

nowcasting_dataset/config/model.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,13 @@ class InputData(BaseModel):
177177
60,
178178
ge=0,
179179
description="how many minutes to forecast in the future. "
180-
"This is defaulted to all the data sources if theya re not set. ",
180+
"This sets the default for all the data sources if they are not set.",
181181
)
182182
default_history_minutes: int = Field(
183183
30,
184184
ge=0,
185185
description="how many historic minutes are used. "
186-
"This is defaulted to all the data sources if theya re not set.",
186+
"This sets the default for all the data sources if they are not set.",
187187
)
188188

189189
@property
@@ -192,12 +192,12 @@ def default_seq_length_5_minutes(self):
192192
return int((self.default_history_minutes + self.default_forecast_minutes) / 5 + 1)
193193

194194
@root_validator
195-
def check_forecast_and_history_minutes(cls, values):
195+
def set_forecast_and_history_minutes(cls, values):
196196
"""
197197
Set default history and forecast values, if needed.
198198
199199
Run through the different data sources and if the forecast or history minutes are not set,
200-
then set them to the default valyes
200+
then set them to the default values
201201
"""
202202

203203
for data_source_name in ["pv", "nwp", "satellite", "gsp", "topographic", "sun"]:

0 commit comments

Comments
 (0)