Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Multi process when saving to netcdf #244

Closed
peterdudfield opened this issue Oct 19, 2021 · 4 comments · Fixed by #245
Closed

Multi process when saving to netcdf #244

peterdudfield opened this issue Oct 19, 2021 · 4 comments · Fixed by #245
Assignees
Labels
enhancement New feature or request

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

Use threading/ mulit cpu when saving batch to netcdf

Context

This will speed up saving to netcdf

Possible Implementation

loop here

@peterdudfield peterdudfield added the enhancement New feature or request label Oct 19, 2021
@JackKelly
Copy link
Member

JackKelly commented Oct 19, 2021

Yeah, I agree... I'm planning to implement this when I rip out the pytorch dataloader, as part of #86 and #213. #202 is particularly relevant.

(nowcasting_dataset should still use mutliple worker processes, thanks to the pytorch dataloader that's still in nowcasting_dataset)

@peterdudfield
Copy link
Contributor Author

Ah perhaps I just mean really specifically, when Batch.save_netcdf() is called, it uses multi process

@JackKelly
Copy link
Member

Good point! That should happen "naturally" as part of #202 (and, in 202, we can use multiple processes per modality)

@peterdudfield
Copy link
Contributor Author

Yea I agree, ive put it in a PR anyway, as it was pretty small and simple. And if it makes a difference then its all good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants