Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Remove Datetime #264

Closed
peterdudfield opened this issue Oct 22, 2021 · 2 comments
Closed

Remove Datetime #264

peterdudfield opened this issue Oct 22, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

Datetime feastures are being made in data_loader on the fly, therefore can remove them here

Possible Implementation

Delete Datetime model in Batch, porbably can remove folder in data_sources/datatime

@peterdudfield peterdudfield added the enhancement New feature or request label Oct 22, 2021
@JackKelly
Copy link
Member

JackKelly commented Oct 22, 2021

Ah, yes, just to clarify (although I'm sure you know this already!)

We should remove the sin and cos datetime features.

We should still leave the datetime fields in the NetCDF files though (so nowcating_dataloader knows the precise datetimes of each timestep)

BTW, unless I've misunderstood, I think this new issue might be a duplicate of #208 ?

@JackKelly JackKelly moved this to Todo in Nowcasting Oct 22, 2021
@peterdudfield
Copy link
Contributor Author

Yea its a duplicate - sorry

@peterdudfield peterdudfield added the duplicate This issue or pull request already exists label Oct 22, 2021
Repository owner moved this from Todo to Done in Nowcasting Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants