Skip to content

Commit bcaa0e8

Browse files
Enable mcad_ray_test
1 parent 8b8563e commit bcaa0e8

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

tests/integration/mcad_ray_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ import (
3434
func TestMCADRay(t *testing.T) {
3535
test := cfosupport.With(t)
3636

37-
test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/issues/190")
38-
3937
// Create a namespace
4038
namespace := test.NewTestNamespace()
4139

@@ -89,7 +87,7 @@ func TestMCADRay(t *testing.T) {
8987
Should(
9088
And(
9189
HaveLen(1),
92-
ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnistjob"))),
90+
ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnisttest"))),
9391
ContainElement(WithTransform(cfosupport.AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive))),
9492
),
9593
)

tests/integration/resources/mnist_ray_mini.ipynb

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"outputs": [],
4141
"source": [
4242
"# Create our cluster and submit appwrapper\n",
43-
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
43+
"cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', head_cpus=2, head_memory=8, num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
4444
]
4545
},
4646
{
@@ -53,18 +53,7 @@
5353
"outputs": [],
5454
"source": [
5555
"# Bring up the cluster\n",
56-
"cluster.up()"
57-
]
58-
},
59-
{
60-
"cell_type": "code",
61-
"execution_count": null,
62-
"id": "a99d5aff",
63-
"metadata": {
64-
"tags": []
65-
},
66-
"outputs": [],
67-
"source": [
56+
"cluster.up()\n",
6857
"cluster.wait_ready()"
6958
]
7059
},
@@ -99,7 +88,7 @@
9988
"metadata": {},
10089
"outputs": [],
10190
"source": [
102-
"job = DDPJobDefinition(name=\"mnisttest\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks/requirements.txt\"}).submit(cluster)"
91+
"job = DDPJobDefinition(name=\"mnisttest\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks-ray/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks-ray/requirements.txt\"}).submit(cluster)"
10392
]
10493
},
10594
{

0 commit comments

Comments
 (0)