Skip to content

Commit 24c9437

Browse files
feat: import FooterSlot from component package instead of slot package (#1682)
1 parent fb6f110 commit 24c9437

File tree

7 files changed

+280
-244
lines changed

7 files changed

+280
-244
lines changed

package-lock.json

+269-235
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"dependencies": {
3535
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
3636
"@edx/browserslist-config": "1.5.0",
37-
"@edx/frontend-component-footer": "^14.3.0",
37+
"@edx/frontend-component-footer": "^14.6.0",
3838
"@edx/frontend-component-header": "^6.2.0",
3939
"@edx/frontend-lib-learning-assistant": "^2.20.0",
4040
"@edx/frontend-lib-special-exams": "^3.5.0",
@@ -47,7 +47,6 @@
4747
"@fortawesome/react-fontawesome": "^0.1.4",
4848
"@openedx/frontend-build": "^14.5.0",
4949
"@openedx/frontend-plugin-framework": "^1.7.0",
50-
"@openedx/frontend-slot-footer": "^1.0.2",
5150
"@openedx/paragon": "^22.16.0",
5251
"@popperjs/core": "2.11.8",
5352
"@reduxjs/toolkit": "1.9.7",

src/generic/CourseAccessErrorPage.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useEffect } from 'react';
22
import { useParams, Navigate } from 'react-router-dom';
33
import { useDispatch, useSelector } from 'react-redux';
44
import { useIntl } from '@edx/frontend-platform/i18n';
5-
import FooterSlot from '@openedx/frontend-slot-footer';
5+
import { FooterSlot } from '@edx/frontend-component-footer';
66
import { LOADED, LOADING } from '@src/constants';
77
import HeaderSlot from '../plugin-slots/HeaderSlot';
88
import useActiveEnterpriseAlert from '../alerts/active-enteprise-alert';

src/generic/PageNotFound.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Hyperlink } from '@openedx/paragon';
33
import { useIntl } from '@edx/frontend-platform/i18n';
44
import { logError } from '@edx/frontend-platform/logging';
55
import { sendTrackEvent } from '@edx/frontend-platform/analytics';
6-
import FooterSlot from '@openedx/frontend-slot-footer';
6+
import { FooterSlot } from '@edx/frontend-component-footer';
77

88
import HeaderSlot from '../plugin-slots/HeaderSlot';
99
import messages from './messages';

src/plugin-slots/FooterSlot/README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
# Footer Slot
22

3-
### Slot ID: `footer_slot`
3+
### Slot ID: `org.openedx.frontend.layout.footer.v1`
4+
5+
### Slot ID Aliases
6+
* `footer_slot`
47

58
## Description
69

710
This slot is used to replace/modify/hide the footer.
811

9-
The implementation of the `FooterSlot` component lives in [the `frontend-slot-footer` repository](https://github.com/openedx/frontend-slot-footer/).
12+
The implementation of the `FooterSlot` component lives in [the `frontend-component-footer` repository](https://github.com/openedx/frontend-component-footer/).
1013

1114
## Example
1215

@@ -23,7 +26,7 @@ import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-frame
2326

2427
const config = {
2528
pluginSlots: {
26-
footer_slot: {
29+
'org.openedx.frontend.layout.footer.v1': {
2730
plugins: [
2831
{
2932
// Hide the default footer

src/plugin-slots/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# `frontend-app-learning` Plugin Slots
22

3-
* [`footer_slot`](./FooterSlot/)
3+
* [`org.openedx.frontend.layout.footer.v1`](./FooterSlot/)
44
* [`org.openedx.frontend.layout.header_learning.v1`](./HeaderSlot/)
55
* [`org.openedx.frontend.learning.content_iframe_loader.v1`](./ContentIFrameLoaderSlot/)
66
* [`org.openedx.frontend.learning.course_breadcrumbs.v1`](./CourseBreadcrumbsSlot/)

src/tab-page/TabPage.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useDispatch, useSelector } from 'react-redux';
55
import { Navigate } from 'react-router-dom';
66

77
import { Toast } from '@openedx/paragon';
8-
import FooterSlot from '@openedx/frontend-slot-footer';
8+
import { FooterSlot } from '@edx/frontend-component-footer';
99
import HeaderSlot from '../plugin-slots/HeaderSlot';
1010
import PageLoading from '../generic/PageLoading';
1111
import { getAccessDeniedRedirectUrl } from '../shared/access';

0 commit comments

Comments
 (0)