-
Notifications
You must be signed in to change notification settings - Fork 2
Remove icons with edX® trademark logos from OpenSource repositories #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove icons with edX® trademark logos from OpenSource repositories #425
Comments
Thanks for your submission, @openedx/openedx-product-managers will review shortly. |
This is reasonable to me. We'll triage this Tuesday at the product WG meeting. |
Need to share collatoral @Cup0fCoffee , then should be good to go |
I'm glad to hear that. Though, I'm not sure what you mean by "share collatoral". If that's something that requires my involvement, could you please clarify? |
@Cup0fCoffee I might be wrong, but this is what I understood from the conversation in the Core Product meeting yesterday... I think @jmakowski1123 is referring to "collateral" as images that illustrate the intended outcome after the change is implemented. In this case, an updated version of this image showing how it should look with the correct logo. If my understanding is correct, I can recreate this image with the correct logo for you. |
Yeah, the image assets are collateral - sorry that wasn't clear! |
@sarina Thanks for confirming! I've created an Open edX version of the image and linked them below. Please confirm whether @Cup0fCoffee can go ahead and use the new image: I've included a png and an svg above as the png looked a bit pixellated—I could always save the png at double size and it could be scaled down in the code. @Cup0fCoffee please let me know which would be better for you. |
Those look good to me! |
@ali-hugo Thank you for creating the new icons on such a short notice! @ali-hugo @sarina There might've been a misunderstanding in the following lines:
I'm not a core contributor and the client(s) that reported the issue didn't provide any budget for us to fix this issue, only to report it. I'm not an assignee (for the lack of a better word) for implementing the change. I've only been asked to report it, which lead to creation of this proposal. Please let me know if any changes to the wording of the proposal are required. Otherwise, the limit of my scope has been reached. |
Thanks, I moved the status to "Not resourced". I think anyone who picks this up should communicate with 2U so they know these images are changing. |
@Cup0fCoffee Thanks for clearing that up. Sorry for introducing the confusion about the responsibilities! |
@Cup0fCoffee How much work would that be? If it's not too much, it could be worth asking the client if they would be willing to contribute that time, to ensure it can't happen again to end up with an edX logo by mistake on a certificate? Especially now that @ali-hugo has already created the images with the Open edX logo, it would be good to close the loop on this. |
@antoviaque The client is now using a custom icon that replaces the default icon via a theme, so they won't benefit from this contribution. I will still ask them though. |
@Cup0fCoffee Thanks! That would still ensure this won't happen on another instance or theme they might have in the future, and would be the equivalent of upstreaming the change in this case. It would also be a way to put to use @ali-hugo 's contribution of an icon, which might get lost otherwise. |
@antoviaque @ali-hugo The client said they'll reconsider in April. |
Hi @Cup0fCoffee. Have there been any more conversations with the client about potentially funding this change? |
@ali-hugo Yes, I actually started working on it yesterday, and should be able to open 2 PRs (for |
Great news! Thanks @Cup0fCoffee. 💐 |
@ali-hugo I found another icon that has edX logo - https://github.com/openedx/frontend-app-learning/blob/open-release/sumac.master/src/generic/assets/edX_locked_certificate.png. Would you be able to create a replacement? I think just a |
@Cup0fCoffee Thanks for spotting that. Here's a png of the Open edX version of the locked certificate. Let me know if you need anything else. |
@sarina I've created two PRs that update the icons:
cc. @ali-hugo @antoviaque |
Abstract
Some repositories of Open edX use icons that contain logos that are trademark logos of edX®. The repositories are meant to be used by the community and Open edX vendors, and the presence of the edX logo makes it look like the hosted instance and/or courses are affiliated by edX. The icons that use the edX trademark logo should be updated to either not use the logo, or should use a different logo (e.g. Open edX).
Detailed Product Proposal
No response
Context & Background (in brief, if a Product Proposal is linked above)
Some of the default icons that are used in the platform contain the edX® trademark logo. The examples that we know of are:
There could be other instances of the logo being used in the icons.
These icons have been added a few years ago and there is no easy way to replace them, if you don't count some CSS shenanigans. It is our understanding that these icons wouldn't make anyone liable for violating the trademark/copyright. The Open edX repositories shouldn't use edX® trademark logo, since these repositories are meant to be used by the community.
Icons that contain the trademark logo should be replaced with a version that doesn't contain edX logo.
Scope & Approach (in brief, if a Product Proposal is linked above)
The initial scope should include the icons that have been mentioned in the "Context & Background" section. Since there is no easy way to scan all images and icons that are used across all Open edX repositories, the list is not exhaustive. As such, once other images/icons are found or reported, they should be added to the scope.
Value & Impact (in brief, if a Product Proposal is linked above)
N/A
Milestones and/or Epics
N/A
Named Release
Teak
Timeline (in brief, if a Product Proposal is linked above)
The initial scope should be complete before Teak release.
Proposed By
OpenCraft
Additional Info
No response
The text was updated successfully, but these errors were encountered: