8314846: Do not store Klass::_secondary_super_cache in CDS archive

Reviewed-by: stuefe, aph

Author: iklam

src/hotspot/share/oops/klass.cpp

@@ -726,7 +726,6 @@ void Klass::metaspace_pointers_do(MetaspaceClosure* it) {
   }
 
   it->push(&_name);
-  it->push(&_secondary_super_cache);
   it->push(&_secondary_supers);
   for (int i = 0; i < _primary_super_limit; i++) {
     it->push(&_primary_supers[i]);
@@ -757,6 +756,11 @@ void Klass::remove_unshareable_info() {
     log_trace(cds, unshareable)("remove: %s", external_name());
   }
 
+  // _secondary_super_cache may be updated by an is_subtype_of() call
+  // while ArchiveBuilder is copying metaspace objects. Let's reset it to
+  // null and let it be repopulated at runtime.
+  set_secondary_super_cache(nullptr);
+
   set_subklass(nullptr);
   set_next_sibling(nullptr);
   set_next_link(nullptr);