Skip to content

Commit f889797

Browse files
committed
8330463: Rename invalidate() to write_region() in ModRefBarrierSet
Reviewed-by: gli, tschatzl
1 parent c4f5c51 commit f889797

7 files changed

+12
-18
lines changed

src/hotspot/share/gc/g1/g1BarrierSet.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ void G1BarrierSet::write_ref_field_post_slow(volatile CardValue* byte) {
102102
}
103103
}
104104

105-
void G1BarrierSet::invalidate(JavaThread* thread, MemRegion mr) {
105+
void G1BarrierSet::write_region(JavaThread* thread, MemRegion mr) {
106106
if (mr.is_empty()) {
107107
return;
108108
}

src/hotspot/share/gc/g1/g1BarrierSet.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ class G1BarrierSet: public CardTableBarrierSet {
4848
return barrier_set_cast<G1BarrierSet>(BarrierSet::barrier_set());
4949
}
5050

51-
void invalidate(JavaThread* thread, MemRegion mr);
52-
5351
public:
5452
G1BarrierSet(G1CardTable* table);
5553
~G1BarrierSet() { }
@@ -73,8 +71,8 @@ class G1BarrierSet: public CardTableBarrierSet {
7371
template <DecoratorSet decorators, typename T>
7472
void write_ref_field_pre(T* field);
7573

76-
inline void invalidate(MemRegion mr);
77-
inline void write_region(JavaThread* thread, MemRegion mr);
74+
inline void write_region(MemRegion mr);
75+
void write_region(JavaThread* thread, MemRegion mr);
7876

7977
inline void write_ref_array_work(MemRegion mr);
8078

src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,12 @@ inline void G1BarrierSet::write_ref_field_pre(T* field) {
6868
enqueue(field);
6969
}
7070

71-
inline void G1BarrierSet::invalidate(MemRegion mr) {
72-
invalidate(JavaThread::current(), mr);
73-
}
74-
75-
inline void G1BarrierSet::write_region(JavaThread* thread, MemRegion mr) {
76-
invalidate(thread, mr);
71+
inline void G1BarrierSet::write_region(MemRegion mr) {
72+
write_region(JavaThread::current(), mr);
7773
}
7874

7975
inline void G1BarrierSet::write_ref_array_work(MemRegion mr) {
80-
invalidate(mr);
76+
write_region(mr);
8177
}
8278

8379
template <DecoratorSet decorators, typename T>

src/hotspot/share/gc/shared/cardTableBarrierSet.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void CardTableBarrierSet::write_ref_array_work(MemRegion mr) {
8484
_card_table->dirty_MemRegion(mr);
8585
}
8686

87-
void CardTableBarrierSet::invalidate(MemRegion mr) {
87+
void CardTableBarrierSet::write_region(MemRegion mr) {
8888
_card_table->dirty_MemRegion(mr);
8989
}
9090

@@ -141,7 +141,7 @@ void CardTableBarrierSet::on_slowpath_allocation_exit(JavaThread* thread, oop ne
141141
thread->set_deferred_card_mark(mr);
142142
} else {
143143
// Do the card mark
144-
invalidate(mr);
144+
write_region(mr);
145145
}
146146
}
147147
#endif // COMPILER2_OR_JVMCI

src/hotspot/share/gc/shared/cardTableBarrierSet.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class CardTableBarrierSet: public ModRefBarrierSet {
6767
void initialize();
6868

6969
void write_region(JavaThread* thread, MemRegion mr) {
70-
invalidate(mr);
70+
write_region(mr);
7171
}
7272

7373
void write_ref_array_work(MemRegion mr);
@@ -80,7 +80,7 @@ class CardTableBarrierSet: public ModRefBarrierSet {
8080
template <DecoratorSet decorators, typename T>
8181
void write_ref_field_post(T* field);
8282

83-
virtual void invalidate(MemRegion mr);
83+
virtual void write_region(MemRegion mr);
8484

8585
// ReduceInitialCardMarks
8686
void initialize_deferred_card_mark_barriers();

src/hotspot/share/gc/shared/modRefBarrierSet.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class ModRefBarrierSet: public BarrierSet {
5252
inline void write_ref_field_post(T *addr) {}
5353

5454
// Causes all refs in "mr" to be assumed to be modified (by this JavaThread).
55-
virtual void invalidate(MemRegion mr) = 0;
55+
virtual void write_region(MemRegion mr) = 0;
5656
// Causes all refs in "mr" to be assumed to be modified by the given JavaThread.
5757
virtual void write_region(JavaThread* thread, MemRegion mr) = 0;
5858

src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ inline void ModRefBarrierSet::AccessBarrier<decorators, BarrierSetT>::
138138
clone_in_heap(oop src, oop dst, size_t size) {
139139
Raw::clone(src, dst, size);
140140
BarrierSetT *bs = barrier_set_cast<BarrierSetT>(barrier_set());
141-
bs->invalidate(MemRegion((HeapWord*)(void*)dst, size));
141+
bs->write_region(MemRegion((HeapWord*)(void*)dst, size));
142142
}
143143

144144
#endif // SHARE_GC_SHARED_MODREFBARRIERSET_INLINE_HPP

0 commit comments

Comments
 (0)