Fix missing constructor argument issue (#492)

* Fix missing constructor argument issue

- fixes #356
- added tests

* Remove unused JavaTemplate import

---------

Co-authored-by: Tim te Beek <[email protected]>

Author: arodionov

src/main/java/org/openrewrite/staticanalysis/NoDoubleBraceInitialization.java

@@ -18,7 +18,6 @@
 import org.openrewrite.*;
 import org.openrewrite.internal.ListUtils;
 import org.openrewrite.java.JavaIsoVisitor;
-import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.search.UsesType;
 import org.openrewrite.java.tree.*;
 import org.openrewrite.marker.Markers;
@@ -123,10 +122,7 @@ public J.NewClass visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
                             Cursor namedVarCursor = getCursor().dropParentUntil(J.VariableDeclarations.NamedVariable.class::isInstance);
                             namedVarCursor.putMessage("DROP_INITIALIZER", Boolean.TRUE);
 
-                            fq = fq.getSupertype();
-                            String newInitializer = " new " + fq.getClassName() + "<>();";
-                            JavaTemplate template = JavaTemplate.builder(newInitializer).imports(fq.getFullyQualifiedName()).build();
-                            nc = template.apply(getCursor(), nc.getCoordinates().replace());
+                            nc = nc.withBody(null);
                             initStatements = addSelectToInitStatements(initStatements, var.getName(), ctx);
                             initStatements.add(0, new J.Assignment(Tree.randomId(), Space.EMPTY, Markers.EMPTY, var.getName().withId(UUID.randomUUID()), JLeftPadded.build(nc), fq));
                             parentBlockCursor.computeMessageIfAbsent("INIT_STATEMENTS", v -> new HashMap<Statement, List<Statement>>()).put(varDeclsCursor.getValue(), initStatements);

src/test/java/org/openrewrite/staticanalysis/NoDoubleBraceInitializationTest.java

@@ -30,6 +30,70 @@ public void defaults(RecipeSpec spec) {
         spec.recipe(new NoDoubleBraceInitialization());
     }
 
+    @Test
+    void dropsConstructorCollectionParameterInMethod() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import java.util.*;
+
+              class A {
+                  void foo() {
+                      Map<String, String> a = Map.of("foo", "bar");
+                      Map<String, String> b = new HashMap<>(a) {{
+                          put("irrelevantKey", "irrelevantValue");
+                      }};
+                  }
+              }
+              """,
+            """
+              import java.util.*;
+
+              class A {
+                  void foo() {
+                      Map<String, String> a = Map.of("foo", "bar");
+                      Map<String, String> b = new HashMap<>(a);
+                      b.put("irrelevantKey", "irrelevantValue");
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/356")
+    @Test
+    void dropsConstructorCollectionParameterInClass() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import java.util.*;
+
+              class A {
+                  Map<String, String> a = Map.of("foo", "bar");
+                  Map<String, String> b = new HashMap<>(a) {{
+                      put("irrelevantKey", "irrelevantValue");
+                  }};
+              }
+              """,
+            """
+              import java.util.*;
+
+              class A {
+                  Map<String, String> a = Map.of("foo", "bar");
+                  Map<String, String> b;
+                  {
+                      b = new HashMap<>(a);
+                      b.put("irrelevantKey", "irrelevantValue");
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Issue("https://github.com/openrewrite/rewrite/issues/2674")
     @Test
     void possibleMistakenlyMissedAddingToCollection() {