Unmarshall error details (#1040)

* update render unmarshal failures
* revamp for pretty format, error.As approach

Upstream-repository: operator-registry
Upstream-commit: 249ae621bb8fa6fc8a8e4a5ae26355577393f127

Signed-off-by: Jordan Keister <[email protected]>

Author: grokspawn

operator-registry.blacklist

@@ -1,2 +1,4 @@
 0b2f43f426f9d621cab7a5224fc260ae3265be1c
 eb2e6393796f397e93618c4aa5038f6a366cdb31
+6e014a3aa10f1754f7ac89ee7c0dd435f85b9d07
+25a478d9040b0f1fd50c5cbae570b013af01c73f

staging/operator-registry/alpha/declcfg/load.go

@@ -1,6 +1,7 @@
 package declcfg
 
 import (
+	"bytes"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -135,7 +136,7 @@ func LoadReader(r io.Reader) (*DeclarativeConfig, error) {
 
 		var in Meta
 		if err := json.Unmarshal(doc, &in); err != nil {
-			return nil, err
+			return nil, fmt.Errorf("unmarshal error: %s", resolveUnmarshalErr(doc, err))
 		}
 
 		switch in.Schema {
@@ -186,3 +187,47 @@ func LoadFile(root fs.FS, path string) (*DeclarativeConfig, error) {
 
 	return cfg, nil
 }
+
+func resolveUnmarshalErr(data []byte, err error) string {
+	var te *json.UnmarshalTypeError
+	if errors.As(err, &te) {
+		return formatUnmarshallErrorString(data, te.Error(), te.Offset)
+	}
+	var se *json.SyntaxError
+	if errors.As(err, &se) {
+		return formatUnmarshallErrorString(data, se.Error(), se.Offset)
+	}
+	return err.Error()
+}
+
+func formatUnmarshallErrorString(data []byte, errmsg string, offset int64) string {
+	sb := new(strings.Builder)
+	_, _ = sb.WriteString(fmt.Sprintf("%s at offset %d (indicated by <==)\n ", errmsg, offset))
+	// attempt to present the erroneous JSON in indented, human-readable format
+	// errors result in presenting the original, unformatted output
+	var pretty bytes.Buffer
+	err := json.Indent(&pretty, data, "", "    ")
+	if err == nil {
+		pString := pretty.String()
+		// calc the prettified string offset which correlates to the original string offset
+		var pOffset, origOffset int64
+		origOffset = 0
+		for origOffset = 0; origOffset < offset; {
+			pOffset++
+			if pString[pOffset] != '\n' && pString[pOffset] != ' ' {
+				origOffset++
+			}
+		}
+		_, _ = sb.WriteString(pString[:pOffset])
+		_, _ = sb.WriteString(" <== ")
+		_, _ = sb.WriteString(pString[pOffset:])
+	} else {
+		for i := int64(0); i < offset; i++ {
+			_ = sb.WriteByte(data[i])
+		}
+		_, _ = sb.WriteString(" <== ")
+		_, _ = sb.Write(data[offset:])
+	}
+
+	return sb.String()
+}