hack/lib: dedup os::util::host_platform and os::build::host_platform

Author: detiber

CONTRIBUTING.adoc

@@ -137,7 +137,7 @@ $ hack/env make release
 In order to make use of the binaries from your shell, add the build output
 directory to the `$PATH`:
 ----
-$ export PATH="${PATH}:$( source hack/lib/init.sh; echo "${OS_OUTPUT_BINPATH}/$( os::util::host_platform )/" )"
+$ export PATH="${PATH}:$( source hack/lib/init.sh; echo "${OS_OUTPUT_BINPATH}/$( os::build::host_platform )/" )"
 ----
 
 See more information in https://github.com/openshift/origin/blob/master/HACKING.md#building-on-non-linux-systems[`HACKING.md`]

hack/lib/cleanup.sh

@@ -292,7 +292,7 @@ readonly -f os::cleanup::find_cache_alterations
 function os::cleanup::dump_pprof_output() {
 	if go tool -n pprof >/dev/null 2>&1 && [[ -s cpu.pprof ]]; then
 		os::log::info "[CLEANUP] \`pprof\` output logged to $( os::util::repository_relative_path "${LOG_DIR}/pprof.out" )"
-		go tool pprof -text "./_output/local/bin/$(os::util::host_platform)/openshift" cpu.pprof >"${LOG_DIR}/pprof.out" 2>&1
+		go tool pprof -text "./_output/local/bin/$(os::build::host_platform)/openshift" cpu.pprof >"${LOG_DIR}/pprof.out" 2>&1
 	fi
 }
 readonly -f os::cleanup::dump_pprof_output

hack/lib/util/environment.sh

@@ -104,7 +104,7 @@ readonly -f os::util::environment::setup_all_server_vars
 function os::util::environment::update_path_var() {
     local prefix
     if os::util::find::system_binary 'go' >/dev/null 2>&1; then
-        prefix+="${OS_OUTPUT_BINPATH}/$(os::util::host_platform):"
+        prefix+="${OS_OUTPUT_BINPATH}/$(os::build::host_platform):"
     fi
     if [[ -n "${GOPATH:-}" ]]; then
         prefix+="${GOPATH}/bin:"

hack/lib/util/misc.sh

@@ -190,21 +190,6 @@ function os::util::curl_etcd() {
 	fi
 }
 
-# os::util::host_platform determines what the host OS and architecture
-# are, as Golang sees it. The go tool chain does some slightly different
-# things when the target platform matches the host platform.
-#
-# Globals:
-#  None
-# Arguments:
-#  None
-# Returns:
-#  None
-function os::util::host_platform() {
-	echo "$(go env GOHOSTOS)/$(go env GOHOSTARCH)"
-}
-readonly -f os::util::host_platform
-
 # os::util::list_go_src_files lists files we consider part of our project
 # source code, useful for tools that iterate over source to provide vet-
 # ting or linting, etc.