Skip to content

Commit bb034d9

Browse files
Skip building release archives during RPM build
1 parent e896431 commit bb034d9

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,6 @@ official-release: build-images build-cross
251251
# Example:
252252
# make release
253253
release: build-images
254-
hack/extract-release.sh
255254
.PHONY: release
256255

257256
# Build the cross compiled release binaries

hack/build-cross.sh

+19-11
Original file line numberDiff line numberDiff line change
@@ -82,17 +82,25 @@ os::build::build_binaries "${OS_CROSS_COMPILE_TARGETS[@]}"
8282
OS_BUILD_PLATFORMS=("${test_platforms[@]+"${test_platforms[@]}"}")
8383
os::build::build_binaries "${OS_TEST_TARGETS[@]}"
8484

85-
# Make the primary client/server release.
86-
OS_BUILD_PLATFORMS=("${platforms[@]+"${platforms[@]}"}")
87-
OS_RELEASE_ARCHIVE="openshift-origin" \
88-
os::build::place_bins "${OS_CROSS_COMPILE_BINARIES[@]}"
89-
90-
# Make the image binaries release.
91-
OS_BUILD_PLATFORMS=("${image_platforms[@]+"${image_platforms[@]}"}")
92-
OS_RELEASE_ARCHIVE="openshift-origin-image" \
93-
os::build::place_bins "${OS_IMAGE_COMPILE_BINARIES[@]}"
94-
95-
os::build::release_sha
85+
if [[ "${OS_BUILD_RELEASE_ARCHIVES-}" != "n" ]]; then
86+
# Make the primary client/server release.
87+
OS_BUILD_PLATFORMS=("${platforms[@]+"${platforms[@]}"}")
88+
OS_RELEASE_ARCHIVE="openshift-origin" \
89+
os::build::place_bins "${OS_CROSS_COMPILE_BINARIES[@]}"
90+
91+
# Make the image binaries release.
92+
OS_BUILD_PLATFORMS=("${image_platforms[@]+"${image_platforms[@]}"}")
93+
OS_RELEASE_ARCHIVE="openshift-origin-image" \
94+
os::build::place_bins "${OS_IMAGE_COMPILE_BINARIES[@]}"
95+
96+
os::build::release_sha
97+
else
98+
# Place binaries only
99+
OS_BUILD_PLATFORMS=("${platforms[@]+"${platforms[@]}"}") \
100+
os::build::place_bins "${OS_CROSS_COMPILE_BINARIES[@]}"
101+
OS_BUILD_PLATFORMS=("${image_platforms[@]+"${image_platforms[@]}"}") \
102+
os::build::place_bins "${OS_IMAGE_COMPILE_BINARIES[@]}"
103+
fi
96104

97105
if [[ "${OS_GIT_TREE_STATE:-dirty}" == "clean" ]]; then
98106
# only when we are building from a clean state can we claim to

origin.spec

+2-2
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ of docker. Exclude those versions of docker.
240240
%if 0%{do_build}
241241
%if 0%{make_redistributable}
242242
# Create Binaries for all supported arches
243-
%{os_git_vars} hack/build-cross.sh
243+
%{os_git_vars} OS_BUILD_RELEASE_ARCHIVES=n hack/build-cross.sh
244244
%{os_git_vars} hack/build-go.sh vendor/github.com/onsi/ginkgo/ginkgo
245245
%{os_git_vars} unset GOPATH; cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog/hack/build-cross.sh
246246
%{os_git_vars} unset GOPATH; cmd/cluster-capacity/go/src/github.com/kubernetes-incubator/cluster-capacity/hack/build-cross.sh
@@ -261,7 +261,7 @@ of docker. Exclude those versions of docker.
261261
%ifarch s390x
262262
BUILD_PLATFORM="linux/s390x"
263263
%endif
264-
OS_ONLY_BUILD_PLATFORMS="${BUILD_PLATFORM}" %{os_git_vars} hack/build-cross.sh
264+
OS_ONLY_BUILD_PLATFORMS="${BUILD_PLATFORM}" %{os_git_vars} OS_BUILD_RELEASE_ARCHIVES=n hack/build-cross.sh
265265
OS_ONLY_BUILD_PLATFORMS="${BUILD_PLATFORM}" %{os_git_vars} hack/build-go.sh vendor/github.com/onsi/ginkgo/ginkgo
266266
OS_ONLY_BUILD_PLATFORMS="${BUILD_PLATFORM}" %{os_git_vars} unset GOPATH; cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog/hack/build-cross.sh
267267
OS_ONLY_BUILD_PLATFORMS="${BUILD_PLATFORM}" %{os_git_vars} unset GOPATH; cmd/cluster-capacity/go/src/github.com/kubernetes-incubator/cluster-capacity/hack/build-cross.sh

0 commit comments

Comments
 (0)