Remove dependency on operator-sdk metrics package

This commit removes the dependency on operator-sdk
metrics package by adding service and service monitors
through package manifests and validating their creation
on operator startup. Since WMCO is no longer creating a
service with selector, no Endpoint object is created.
This commit also ensures we create an Endpoints object
before accessing it. We cannot create Endpoints resources
through manifests as they are not currently OLM supported
operator-framework/operator-lifecycle-manager#1996

Author: VaishnaviHire

cmd/manager/main.go

@@ -22,7 +22,7 @@ import (
 	"github.com/openshift/windows-machine-config-operator/apis"
 	"github.com/openshift/windows-machine-config-operator/controllers"
 	"github.com/openshift/windows-machine-config-operator/pkg/cluster"
-	winmetrics "github.com/openshift/windows-machine-config-operator/pkg/metrics"
+	"github.com/openshift/windows-machine-config-operator/pkg/metrics"
 	"github.com/openshift/windows-machine-config-operator/pkg/nodeconfig/payload"
 	"github.com/openshift/windows-machine-config-operator/version"
 )
@@ -131,7 +131,7 @@ func main() {
 	// Create a new Cmd to provide shared dependencies and start components
 	mgr, err := manager.New(cfg, manager.Options{
 		NewCache:           cache.MultiNamespacedCacheBuilder(namespaces),
-		MetricsBindAddress: fmt.Sprintf("%s:%d", winmetrics.Host, winmetrics.Port),
+		MetricsBindAddress: fmt.Sprintf("%s:%d", metrics.Host, metrics.Port),
 	})
 	if err != nil {
 		log.Error(err, "failed to create a new Manager")
@@ -152,9 +152,16 @@ func main() {
 		os.Exit(1)
 	}
 
-	// Add the Metrics Service and Service Monitor
-	if err := winmetrics.Add(ctx, cfg, namespace); err != nil {
-		log.Error(err, "failed to add Metrics Service and Service Monitor")
+	metricsConfig, err := metrics.NewConfig(mgr, cfg, namespace)
+	if err != nil {
+		log.Error(err, "failed to create MetricsConfig object")
+		os.Exit(1)
+	}
+
+	// Configure the metric resources
+	if err := metricsConfig.Configure(ctx); err != nil {
+		log.Error(err, "error setting up metrics")
+		os.Exit(1)
 	}
 
 	log.Info("starting the Cmd.")

deploy/olm-catalog/windows-machine-config-operator/manifests/service-monitor.yaml

@@ -0,0 +1,23 @@
+# Prometheus Monitor Service (Metrics)
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+  labels:
+    name: windows-machine-config-operator
+  name: windows-machine-config-operator-metrics
+spec:
+  endpoints:
+    - path: /metrics
+      port: metrics
+      interval: 30s
+      honorLabels: true
+      relabelings:
+        - action: replace
+          regex: (.*)
+          replacement: $1
+          sourceLabels:
+            - __meta_kubernetes_endpoint_address_target_name
+          targetLabel: instance
+  selector:
+    matchLabels:
+      name: windows-machine-config-operator

deploy/olm-catalog/windows-machine-config-operator/manifests/service.yaml

@@ -0,0 +1,12 @@
+kind: Service
+apiVersion: v1
+metadata:
+  name: windows-machine-config-operator-metrics
+  labels:
+    name: windows-machine-config-operator
+spec:
+  ports:
+    - name: metrics
+      protocol: TCP
+      port: 9182
+      targetPort: 9182

deploy/olm-catalog/windows-machine-config-operator/manifests/windows-machine-config-operator.clusterserviceversion.yaml

@@ -283,8 +283,6 @@ spec:
           - create
           - delete
           - get
-          - update
-          - patch
         - apiGroups:
           - ""
           resources:
@@ -303,16 +301,20 @@ spec:
           - create
           - get
           - update
+        - apiGroups:
+          - ""
+          resources:
+          - namespaces
+          verbs:
+          - get
         - apiGroups:
           - monitoring.coreos.com
           resources:
           - servicemonitors
           verbs:
           - get
           - create
-          - update
           - list
-          - patch
           - delete
         - apiGroups:
           - apps

deploy/role.yaml

@@ -23,8 +23,6 @@ rules:
   - create
   - delete
   - get
-  - update
-  - patch
 - apiGroups:
     - ""
   resources:
@@ -43,16 +41,20 @@ rules:
   - create
   - get
   - update
+- apiGroups:
+  - ""
+  resources:
+  - namespaces
+  verbs:
+  - get
 - apiGroups:
   - monitoring.coreos.com
   resources:
   - servicemonitors
   verbs:
   - get
   - create
-  - update
   - list
-  - patch
   - delete
 # deployment/finalizers permissions needed for the metrics server
 - apiGroups: