OCPEDGE-1703: Add workload partitioning and two node fencing block to install config (#1740)

* feat: add workload partitioning

add workload partitioning to install config
renamed arbiter stanza function to follow more common bash conventions
simplify if logic

Signed-off-by: ehila <[email protected]>

* feat: add control plane fencing credentials

added ability to enable fencing credentials for Two Node Fencing deployments (TNA) when number of masters is 2 and arbiter is not enabled

Signed-off-by: ehila <[email protected]>

---------

Signed-off-by: ehila <[email protected]>

Author: eggfoobar

config_example.sh

@@ -462,6 +462,16 @@ set -x
 #
 #export ENABLE_ARBITER=1
 
+# ENABLE_WORKLOAD_PARTITIONING -
+# Set to any non zero length string value to enable workload partitioning in the install config.
+#
+# Workload partitioning allows for workloads to be pinned to specific CPUSets with Performance Profiles
+# from the Node Tuning Operator.
+# For more info see:
+# https://github.com/openshift/cluster-node-tuning-operator/blob/main/docs/performanceprofile/performance_profile.md
+#
+#export ENABLE_WORKLOAD_PARTITIONING=true
+
 # MASTER_HOSTNAME_FORMAT -
 # Set a custom hostname format for masters. This is a format string that should
 # include one %d field, which will be replaced with the number of the node.

ocp_install_env.sh

@@ -181,8 +181,8 @@ EOF
     fi
 }
 
-function arbiterStanza() {
-    if [[ ! -z "${ENABLE_ARBITER:-}" ]]; then
+function arbiter_stanza() {
+    if [[ -n "${ENABLE_ARBITER:-}" ]]; then
 cat <<EOF
 arbiter:
   name: arbiter
@@ -195,6 +195,14 @@ EOF
     fi
 }
 
+function workload_partitioning() {
+  if [[ -n "${ENABLE_WORKLOAD_PARTITIONING}" ]]; then
+cat <<EOF
+cpuPartitioningMode: AllNodes
+EOF
+  fi
+}
+
 function libvirturi() {
     if [[ "$REMOTE_LIBVIRT" -ne 0 ]]; then
 cat <<EOF
@@ -313,6 +321,7 @@ function generate_ocp_install_config() {
     cat > "${outdir}/install-config.yaml" << EOF
 apiVersion: v1
 baseDomain: ${BASE_DOMAIN}
+$(workload_partitioning)
 networking:
   networkType: ${NETWORK_TYPE}
 $(cluster_network)
@@ -328,7 +337,8 @@ controlPlane:
   architecture: $(get_arch install_config)
   platform:
     baremetal: {}
-$(arbiterStanza)
+$(node_map_to_install_config_fencing_credentials)
+$(arbiter_stanza)
 $(featureSet)
 platform:
   baremetal:

utils.sh

@@ -303,6 +303,29 @@ EOF
     done
 }
 
+function node_map_to_install_config_fencing_credentials() {
+  if  [[ -z "${ENABLE_ARBITER:-}" ]] && [[ "${NUM_MASTERS}" -eq 2 ]]; then
+	cat <<EOF
+  fencing:
+    credentials:
+EOF
+    for ((idx=0;idx<$(($NUM_MASTERS));idx++)); do
+      name=$(node_val ${idx} "name")
+      username=$(node_val ${idx} "driver_info.username")
+      password=$(node_val ${idx} "driver_info.password")
+      address=$(node_val ${idx} "driver_info.address")
+
+      cat <<EOF
+    - hostname: ${name}
+      address: ${address}
+      username: ${username}
+      password: ${password}
+      sslInsecure: true
+EOF
+	done
+	fi
+}
+
 function sync_repo_and_patch {
     REPO_PATH=${REPO_PATH:-$HOME}
     DEST="${REPO_PATH}/$1"