Skip to content

Commit cf63ad9

Browse files
chmouelenarha
andcommitted
fix(docs): correct grammar and improve clarity
- Corrected grammatical errors in multiple documentation files. - Improved clarity and readability of the content. - Ensured consistency in terminology and formatting. Signed-off-by: Chmouel Boudjnah <[email protected]> Co-authored-by: Emil Natan <[email protected]> Signed-off-by: Chmouel Boudjnah <[email protected]>
1 parent 93fe8e8 commit cf63ad9

File tree

9 files changed

+293
-342
lines changed

9 files changed

+293
-342
lines changed

docs/content/dev/_index.md

+57-57
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,37 @@ It uses kind under docker. You start it with:
1616
make dev
1717
```
1818

19-
When it finished you will have the following installed in your kind cluster:
19+
When it finishes, you will have the following installed in your kind cluster:
2020

2121
- Kind Cluster deployment
2222
- Internal registry to push to from `ko`
23-
- A ingress controller with nginx for routing.
24-
- Tekton and Dashboard installed with a ingress route.
23+
- An ingress controller with nginx for routing.
24+
- Tekton and Dashboard installed with an ingress route.
2525
- Pipelines as code deployed from your repo with ko.
26-
- Gitea service running locally so you can run your E2E tests that targets gitea (the most comprehensive ones)
26+
- Gitea service running locally so you can run the E2E tests against it (Gitea has the most comprehensive set of tests).
2727

28-
By default it will try to install from
29-
$GOPATH/src/github.com/openshift-pipelines/pipelines-as-code, if you want to
30-
override it you can set the `PAC_DIRS` environment variable.
28+
By default, it will try to install from
29+
$GOPATH/src/github.com/openshift-pipelines/pipelines-as-code. To override it,
30+
set the `PAC_DIRS` environment variable.
3131

32-
- It will deploy under the nip.io domain reflector, the URL will be :
32+
- It will deploy under the nip.io domain reflector, the URL will be:
3333

3434
- <http://controller.paac-127-0-0-1.nip.io>
3535
- <http://dashboard.paac-127-0-0-1.nip.io>
3636

37-
- You will need to create secret yourself, if you have the [pass cli](https://www.passwordstore.org/)
38-
installed you can point to a folder which contains : github-application-id github-private-key webhook.secret
39-
As configured from your GitHub application. Configure `PAC_PASS_SECRET_FOLDER`
37+
- You will need to create the secret yourself. If you have the [pass cli](https://www.passwordstore.org/)
38+
installed, you can point to a folder that contains: github-application-id, github-private-key, webhook.secret
39+
as configured from your GitHub application. Set the `PAC_PASS_SECRET_FOLDER`
4040
environment variable to point to it.
41-
For example :
41+
For example:
4242

4343
```shell
4444
pass insert github-app/github-application-id
4545
pass insert github-app/webhook.secret
4646
pass insert -m github-app/github-private-key
4747
```
4848

49-
- If you need to redeploy your pac install (and only pac) you can do :
49+
- If you need to redeploy your pac install (and only pac), you can do:
5050

5151
```shell
5252
./hack/dev/kind/install.sh -p
@@ -58,16 +58,16 @@ override it you can set the `PAC_DIRS` environment variable.
5858
make rdev
5959
```
6060

61-
or you can do this directly with ko :
61+
or you can do this directly with ko:
6262

6363
```shell
6464
env KO_DOCKER_REPO=localhost:5000 ko apply -f ${1:-"config"} -B
6565
```
6666

6767
- more flags: `-b` to only do the kind creation+nginx+docker image, `-r` to
68-
install from latest stable release (override with env variable `PAC_RELEASE`)
69-
instead of ko. `-c` will only do the pac configuration (ie: creation of
70-
secrets/ingress etc..)
68+
install from the latest stable release (override with the env variable `PAC_RELEASE`)
69+
instead of ko. `-c` will only do the pac configuration (i.e., creation of
70+
secrets/ingress, etc..)
7171

7272
- see the [install.sh](https://github.com/openshift-pipelines/pipelines-as-code/blob/main/hack/dev/kind/install.sh) -h for all flags
7373

@@ -114,8 +114,8 @@ stringData:
114114
webhook: "" # make sure it's empty when you set this up on the interface and here
115115
```
116116
117-
There is some gotchas with the webhook validation secret, Pipelines-as-Code
118-
detect a Gitea install and let the user set a empty webhook secret (by default
117+
There are some gotchas with the webhook validation secret. Pipelines-as-Code
118+
detects a Gitea install and lets the user set an empty webhook secret (by default
119119
it's enforced).
120120
121121
The `install.sh` script will by default spin up a new instance of GITEA to play
@@ -124,26 +124,26 @@ with and run the Gitea E2E tests.
124124
You will need to create a Hook URL generated from <https://hook.pipelinesascode.com/new>
125125
into the environment variable `TEST_GITEA_SMEEURL`.
126126

127-
The defaults are :
127+
The defaults are:
128128

129129
- URL: <https://localhost:3000/>
130130
- Admin Username: pac
131131
- Admin Password: pac
132132

133-
The E2E tests will automatically create repo using the admin username for each tests.
133+
The E2E tests will automatically create a repo using the admin username for each test.
134134

135135
## Debugging E2E
136136

137-
As long you have the secrets setup you should be able to run the e2e tests properly.
138-
Gitea are the easiest to run (since they are self contained), for the other you
139-
will need to setup some environment variables.
137+
As long as you have the secrets set up, you should be able to run the e2e tests properly.
138+
Gitea is the easiest to run (since they are self-contained). For the rest,
139+
you will need to set up some environment variables.
140140

141141
See the [e2e on kind
142142
workflow](https://github.com/openshift-pipelines/pipelines-as-code/blob/8f990bf5f348f6529deaa3693257907b42287a35/.github/workflows/kind-e2e-tests.yaml#L90)
143-
for all the variables set by provider.
143+
for all the variables set by the provider.
144144

145-
By default the E2E tests cleanups after themselves if you want to keep the
146-
PR/MR opens and the namespace where the test has been created you can set the
145+
By default, the E2E tests clean up after themselves. If you want to keep the
146+
PR/MR open and the namespace where the test has been created, you can set the
147147
`TEST_NOCLEANUP` environment variable to `true`.
148148

149149
## Debugging controller
@@ -154,31 +154,31 @@ to your locally installed controller (this can be either run on your debugger or
154154
inside kind).
155155

156156
An option of gosmee is to save the replay to a directory with `--saveDir
157-
/tmp/save`. If go to that directory a shell script will be created to replay
157+
/tmp/save`. If you go to that directory, a shell script will be created to replay
158158
the request that was sent directly to the controller without having to go through
159159
another push.
160160

161-
Use [snazy](https://github.com/chmouel/snazy) to watch the logs, it support pac
161+
Use [snazy](https://github.com/chmouel/snazy) to watch the logs. It supports pac
162162
by adding some context like which GitHub provider.
163163

164164
![snazy screenshot](/images/pac-snazy.png)
165165

166166
## Using the Makefile targets
167167

168-
Several target in the Makefile is available, if you need to run them
168+
Several targets are available in the Makefile if you want to run them
169169
manually. You can list all the makefile targets with:
170170

171171
```shell
172172
make help
173173
```
174174

175-
For example to test and lint the go files :
175+
For example, to test and lint the go files:
176176

177177
```shell
178178
make test lint-go
179179
```
180180

181-
If you add a CLI command with help you will need to regenerate the golden files :
181+
If you add a CLI command with help, you will need to regenerate the golden files:
182182

183183
```shell
184184
make update-golden
@@ -190,27 +190,27 @@ We are using several tools to verify that pipelines-as-code is up to a good
190190
coding and documentation standard. We use pre-commit tools to ensure before you
191191
send your PR that the commit is valid.
192192

193-
First you need to install pre-commit:
193+
First, you need to install pre-commit:
194194

195195
<https://pre-commit.com/>
196196

197-
It should be available as package on Fedora and Brew or install it with `pip`.
197+
It should be available as a package on Fedora and Brew or install it with `pip`.
198198

199-
When you have it installed add the hook to your repo by doing :
199+
Once installed, add the hook to your repo by doing:
200200

201201
```shell
202202
pre-commit install
203203
```
204204

205-
This will run several `hooks` on the files that has been changed before you
205+
This will run several `hooks` on the files that have been changed before you
206206
_push_ to your remote branch. If you need to skip the verification (for whatever
207-
reason), you can do :
207+
reason), you can do:
208208

209209
```shell
210210
git push --no-verify
211211
```
212212

213-
or you can disable individual hook with the `SKIP` variable:
213+
or you can disable an individual hook with the `SKIP` variable:
214214

215215
```shell
216216
SKIP=lint-md git push
@@ -240,10 +240,10 @@ generated) and start the Hugo server with a live preview of the docs on:
240240

241241
<https://localhost:1313>
242242

243-
When we push the release, the docs gets rebuilt automatically by CloudFare pages.
243+
When we push the release, the docs get rebuilt automatically by CloudFare pages.
244244

245-
By default the website <https://pipelinesascode.com> only contains the "stable"
246-
documentation. If you want to preview the dev documentation as from `main` you
245+
By default, the website <https://pipelinesascode.com> only contains the "stable"
246+
documentation. If you want to preview the dev documentation as from `main`, you
247247
need to go to this URL:
248248

249249
<https://main.pipelines-as-code.pages.dev>
@@ -259,12 +259,12 @@ major version.
259259

260260
### Go Modules
261261

262-
Unless if we that's not possible we try to update all dependencies to the
263-
latest version as long it's compatible with the Pipeline version as shipped by
262+
Unless that's not possible, we try to update all dependencies to the
263+
latest version as long as it's compatible with the Pipeline version as shipped by
264264
OpenShift Pipelines Operator (which should be conservative).
265265

266-
Every time you do a go modules update check if we can remove the `replace`
267-
clause that pins a dependency to a specific version/commit or match the replace
266+
Every time you update the Go modules, check if you can remove the `replace`
267+
clause which pins a dependency to a specific version/commit or match the replace
268268
to the tektoncd/pipeline version.
269269

270270
- Update all go modules:
@@ -274,18 +274,18 @@ to the tektoncd/pipeline version.
274274
make vendor
275275
```
276276

277-
- Go to <https://github.com/google/go-github> and note the latest go version for example: v59
278-
- Open a file that use the go-github library (ie: pkg/provider/github/detect.go) and check the old version, for example: v56
277+
- Go to <https://github.com/google/go-github> and note the latest go version, for example: v59
278+
- Open a file that uses the go-github library (i.e., pkg/provider/github/detect.go) and check the old version, for example: v56
279279

280280
- Run this sed command:
281281

282282
```shell
283283
find -name '*.go'|xargs sed -i 's,github.com/google/go-github/v56,github.com/google/go-github/v59,'
284284
```
285285

286-
- This will update everything, sometime the library ghinstallation is not
286+
- This will update everything. Sometimes the library ghinstallation is not
287287
updated with the new version, so you will need to keep the old version kept in
288-
there. For example you will get this kind of error:
288+
there. For example, you will get this kind of error:
289289

290290
```text
291291
pkg/provider/github/parse_payload.go:56:33: cannot use &github.InstallationTokenOptions{…} (value of type *"github.com/google/go-github/v59/github".InstallationTokenOptions) as *"github.com/google/go-github/v57/github".InstallationTokenOptions value in assignment
@@ -297,10 +297,10 @@ there. For example you will get this kind of error:
297297
make allbinaries test lint
298298
```
299299

300-
- Some structs needs to be updated, some of them are going to fail on
301-
deprecated, so you will need to figure how to update them. Don't be lazy and avoid the
302-
update with a nolint or a pin to a dep you only delay the inevitable until
303-
the problem come back and hit you harder.
300+
- Some structs need to be updated. Some of them are going to fail as
301+
deprecated, so you will need to figure out how to update them. Don't be lazy and avoid the
302+
update with a nolint or a pin to a dep. You only delay the inevitable until
303+
the problem comes back and hits you harder.
304304

305305
### Go version
306306

@@ -311,7 +311,7 @@ there. For example you will get this kind of error:
311311
docker run golang go version
312312
```
313313

314-
- If this not the same as what we have in go.mod then you need to update the go.mod version. then you need to update for example here 1.20:
314+
- If this is not the same as what we have in go.mod, then you need to update the go.mod version. Then you need to update, for example, here 1.20:
315315

316316
```shell
317317
go mod tidy -go=1.20
@@ -340,7 +340,7 @@ there. For example you will get this kind of error:
340340

341341
## Tools that are useful
342342

343-
Several tools are used on CI and in `pre-commit`, the non exhaustive list you
343+
Several tools are used in CI and `pre-commit`. The non-exhaustive list you
344344
need to have on your system:
345345

346346
- [golangci-lint](https://github.com/golangci/golangci-lint) - For golang lint
@@ -362,8 +362,8 @@ need to have on your system:
362362

363363
## Target architecture
364364

365-
- We target arm64 and amd64, the dogfooding is on arm64, so we need to make
366-
sure that all jobs and docker images used in the .tekton PipelineRuns are built
365+
- We target arm64 and amd64. The dogfooding is on arm64, so we need to ensure
366+
that all jobs and docker images used in the .tekton PipelineRuns are built
367367
for arm64.
368368

369369
# Links

0 commit comments

Comments
 (0)