You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By default the E2E tests cleanups after themselves if you want to keep the
146
-
PR/MR opens and the namespace where the test has been created you can set the
145
+
By default, the E2E tests clean up after themselves. If you want to keep the
146
+
PR/MR open and the namespace where the test has been created, you can set the
147
147
`TEST_NOCLEANUP`environment variable to `true`.
148
148
149
149
## Debugging controller
@@ -154,31 +154,31 @@ to your locally installed controller (this can be either run on your debugger or
154
154
inside kind).
155
155
156
156
An option of gosmee is to save the replay to a directory with `--saveDir
157
-
/tmp/save`. If go to that directory a shell script will be created to replay
157
+
/tmp/save`. If you go to that directory, a shell script will be created to replay
158
158
the request that was sent directly to the controller without having to go through
159
159
another push.
160
160
161
-
Use [snazy](https://github.com/chmouel/snazy) to watch the logs, it support pac
161
+
Use [snazy](https://github.com/chmouel/snazy) to watch the logs. It supports pac
162
162
by adding some context like which GitHub provider.
163
163
164
164

165
165
166
166
## Using the Makefile targets
167
167
168
-
Several target in the Makefile is available, if you need to run them
168
+
Several targets are available in the Makefile if you want to run them
169
169
manually. You can list all the makefile targets with:
170
170
171
171
```shell
172
172
make help
173
173
```
174
174
175
-
For example to test and lint the go files:
175
+
For example, to test and lint the go files:
176
176
177
177
```shell
178
178
make test lint-go
179
179
```
180
180
181
-
If you add a CLI command with help you will need to regenerate the golden files:
181
+
If you add a CLI command with help, you will need to regenerate the golden files:
182
182
183
183
```shell
184
184
make update-golden
@@ -190,27 +190,27 @@ We are using several tools to verify that pipelines-as-code is up to a good
190
190
coding and documentation standard. We use pre-commit tools to ensure before you
191
191
send your PR that the commit is valid.
192
192
193
-
First you need to install pre-commit:
193
+
First, you need to install pre-commit:
194
194
195
195
<https://pre-commit.com/>
196
196
197
-
It should be available as package on Fedora and Brew or install it with `pip`.
197
+
It should be available as a package on Fedora and Brew or install it with `pip`.
198
198
199
-
When you have it installed add the hook to your repo by doing:
199
+
Once installed, add the hook to your repo by doing:
200
200
201
201
```shell
202
202
pre-commit install
203
203
```
204
204
205
-
This will run several `hooks` on the files that has been changed before you
205
+
This will run several `hooks` on the files that have been changed before you
206
206
_push_ to your remote branch. If you need to skip the verification (for whatever
207
-
reason), you can do:
207
+
reason), you can do:
208
208
209
209
```shell
210
210
git push --no-verify
211
211
```
212
212
213
-
or you can disable individual hook with the `SKIP` variable:
213
+
or you can disable an individual hook with the `SKIP` variable:
214
214
215
215
```shell
216
216
SKIP=lint-md git push
@@ -240,10 +240,10 @@ generated) and start the Hugo server with a live preview of the docs on:
240
240
241
241
<https://localhost:1313>
242
242
243
-
When we push the release, the docs gets rebuilt automatically by CloudFare pages.
243
+
When we push the release, the docs get rebuilt automatically by CloudFare pages.
244
244
245
-
By default the website <https://pipelinesascode.com> only contains the "stable"
246
-
documentation. If you want to preview the dev documentation as from `main` you
245
+
By default, the website <https://pipelinesascode.com> only contains the "stable"
246
+
documentation. If you want to preview the dev documentation as from `main`, you
247
247
need to go to this URL:
248
248
249
249
<https://main.pipelines-as-code.pages.dev>
@@ -259,12 +259,12 @@ major version.
259
259
260
260
### Go Modules
261
261
262
-
Unless if we that's not possible we try to update all dependencies to the
263
-
latest version as long it's compatible with the Pipeline version as shipped by
262
+
Unless that's not possible, we try to update all dependencies to the
263
+
latest version as long as it's compatible with the Pipeline version as shipped by
264
264
OpenShift Pipelines Operator (which should be conservative).
265
265
266
-
Every time you do a go modules update check if we can remove the `replace`
267
-
clause that pins a dependency to a specific version/commit or match the replace
266
+
Every time you update the Go modules, check if you can remove the `replace`
267
+
clause which pins a dependency to a specific version/commit or match the replace
268
268
to the tektoncd/pipeline version.
269
269
270
270
- Update all go modules:
@@ -274,18 +274,18 @@ to the tektoncd/pipeline version.
274
274
make vendor
275
275
```
276
276
277
-
- Go to <https://github.com/google/go-github> and note the latest go version for example: v59
278
-
- Open a file that use the go-github library (ie:pkg/provider/github/detect.go) and check the old version, for example: v56
277
+
- Go to <https://github.com/google/go-github> and note the latest go version, for example: v59
278
+
- Open a file that uses the go-github library (i.e., pkg/provider/github/detect.go) and check the old version, for example: v56
279
279
280
280
- Run this sed command:
281
281
282
282
```shell
283
283
find -name '*.go'|xargs sed -i 's,github.com/google/go-github/v56,github.com/google/go-github/v59,'
284
284
```
285
285
286
-
- This will update everything, sometime the library ghinstallation is not
286
+
- This will update everything. Sometimes the library ghinstallation is not
287
287
updated with the new version, so you will need to keep the old version kept in
288
-
there. For example you will get this kind of error:
288
+
there. For example, you will get this kind of error:
289
289
290
290
```text
291
291
pkg/provider/github/parse_payload.go:56:33: cannot use &github.InstallationTokenOptions{…} (value of type *"github.com/google/go-github/v59/github".InstallationTokenOptions) as *"github.com/google/go-github/v57/github".InstallationTokenOptions value in assignment
@@ -297,10 +297,10 @@ there. For example you will get this kind of error:
297
297
make allbinaries test lint
298
298
```
299
299
300
-
- Some structs needs to be updated, some of them are going to fail on
301
-
deprecated, so you will need to figure how to update them. Don't be lazy and avoid the
302
-
update with a nolint or a pin to a dep you only delay the inevitable until
303
-
the problem come back and hit you harder.
300
+
- Some structs need to be updated. Some of them are going to fail as
301
+
deprecated, so you will need to figure out how to update them. Don't be lazy and avoid the
302
+
update with a nolint or a pin to a dep. You only delay the inevitable until
303
+
the problem comes back and hits you harder.
304
304
305
305
### Go version
306
306
@@ -311,7 +311,7 @@ there. For example you will get this kind of error:
311
311
docker run golang go version
312
312
```
313
313
314
-
- If this not the same as what we have in go.mod then you need to update the go.mod version. then you need to update for example here 1.20:
314
+
- If this is not the same as what we have in go.mod, then you need to update the go.mod version. Then you need to update, for example, here 1.20:
315
315
316
316
```shell
317
317
go mod tidy -go=1.20
@@ -340,7 +340,7 @@ there. For example you will get this kind of error:
340
340
341
341
## Tools that are useful
342
342
343
-
Several tools are used on CI and in `pre-commit`, the nonexhaustive list you
343
+
Several tools are used in CI and `pre-commit`. The non-exhaustive list you
344
344
need to have on your system:
345
345
346
346
- [golangci-lint](https://github.com/golangci/golangci-lint) - For golang lint
@@ -362,8 +362,8 @@ need to have on your system:
362
362
363
363
## Target architecture
364
364
365
-
- We target arm64 and amd64, the dogfooding is on arm64, so we need to make
366
-
sure that all jobs and docker images used in the .tekton PipelineRuns are built
365
+
- We target arm64 and amd64. The dogfooding is on arm64, so we need to ensure
366
+
that all jobs and docker images used in the .tekton PipelineRuns are built
0 commit comments