Skip to content

Question about events and pipelineRuns #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SJOS opened this issue Jun 29, 2023 · 4 comments · May be fixed by #2095
Open

Question about events and pipelineRuns #1342

SJOS opened this issue Jun 29, 2023 · 4 comments · May be fixed by #2095
Assignees
@chmouel
Labels
question Further information is requested

Comments

@SJOS
Copy link

SJOS commented Jun 29, 2023

In Jenkins, with the multiBranchPipeline plugin, that most people these days use against their git repos, one can choose if a push to a branch that has a pull request should trigger two executions, i.e. one for push and one for pull request, or if only the one for the pull request should be triggered. In the same situation in Tekton PAC, both events will come and I can get separate runs for both events.

Would it at be possible to get the same kind of option in Tekton PAC as in Jenkins, i.e. that I configure my Repository to suppress "push" if there is also a "pull_request" event for the same branch? Or that my pipelineRun could have a flag that is read and understood that it wants to run for "push" but only if no "pull_request" event also has the same origin?
@SJOS SJOS closed this as completed Jul 6, 2023
@chmouel
Copy link
Member

chmouel commented Jul 6, 2023

hello, sorry i forgot to reply to this issue..

i was not aware that jenkins had that option, and that's a nice solution to a problem that always bugged me but never spent too much time on it.... this will solve the issue wheen sending a push from a branch on the same repository generating a push pipeline...

i am not sure we need to make it optional we can just say that a push to a branch who has a pull request open will only generate a pull request event..
'
let's keep this issue open if you don't mind and let's see if we can implement this

@chmouel chmouel reopened this Jul 6, 2023
@SJOS
Copy link
Author

SJOS commented Jul 7, 2023

Thanks for the answer. And this sounds good to me. Only getting one event sounds like what most user would want to happen.

@indiealexh
Copy link

Came looking to see if this was a discussion in progress already. Glad it is as seeing two runs is bugging me :D

@chmouel
Copy link
Member

chmouel commented Sep 19, 2023

thanks for the reminder @indiealexh i created a story in rht jira so this gets prioritized https://issues.redhat.com/browse/SRVKP-3512

@chmouel chmouel self-assigned this May 21, 2025
@chmouel chmouel linked a pull request May 21, 2025 that will close this issue
Open
13 tasks
@chmouel chmouel added the question Further information is requested label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chmouel chmouel

Labels
question Further information is requested
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement setting to skip push events for PR commits chmouel/pipelines-as-code
3 participants
@chmouel @indiealexh @SJOS