Skip to content

Commit d4a64ec

Browse files
Merge pull request #448 from ironcladlou/ingress-scope-fix
Bug 1756141: Remove incorrect optional tag from new ingress field
2 parents cdbe64f + 535221b commit d4a64ec

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

operator/v1/types_ingress.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ type IngressControllerSpec struct {
7070
// If unset, the default is based on
7171
// infrastructure.config.openshift.io/cluster .status.platform:
7272
//
73-
// AWS: LoadBalancerService
74-
// Azure: LoadBalancerService
75-
// GCP: LoadBalancerService
73+
// AWS: LoadBalancerService (with External scope)
74+
// Azure: LoadBalancerService (with External scope)
75+
// GCP: LoadBalancerService (with External scope)
7676
// Libvirt: HostNetwork
7777
//
7878
// Any other platform types (including None) default to HostNetwork.
@@ -186,9 +186,10 @@ var (
186186
// LoadBalancerStrategy holds parameters for a load balancer.
187187
type LoadBalancerStrategy struct {
188188
// scope indicates the scope at which the load balancer is exposed.
189-
// Possible values are "External" and "Internal". The default is
190-
// "External".
191-
// +optional
189+
// Possible values are "External" and "Internal".
190+
//
191+
// +kubebuilder:validation:Required
192+
// +required
192193
Scope LoadBalancerScope `json:"scope"`
193194
}
194195

operator/v1/zz_generated.swagger_doc_generated.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)