generatename for templates

Author: miyadav

pkg/capi/gcp.go

@@ -20,14 +20,15 @@ import (
 )
 
 const (
-	gcpMachineTemplateName     = "gcp-machine-template"
-	OnHostMaintenanceTerminate = "Terminate"
-	OnHostMaintenanceMigrate   = "Migrate"
+	gcpMachineTemplateNamePrefix = "gcp-machine-template-"
+	OnHostMaintenanceTerminate   = "Terminate"
+	OnHostMaintenanceMigrate     = "Migrate"
 )
 
 var (
-	clusterName string
-	cl          client.Client
+	clusterName            string
+	cl                     client.Client
+	gcpMachineTemplateName string
 )
 
 var _ = Describe("Cluster API GCP MachineSet", framework.LabelCAPI, framework.LabelDisruptive, Ordered, func() {
@@ -60,6 +61,11 @@ var _ = Describe("Cluster API GCP MachineSet", framework.LabelCAPI, framework.La
 		framework.CreateCoreCluster(ctx, cl, clusterName, "GCPCluster")
 		mapiMachineSpec = getGCPMAPIProviderSpec(cl)
 	})
+
+	BeforeEach(func() {
+		gcpMachineTemplateName = fmt.Sprintf("%s%s", gcpMachineTemplateNamePrefix, framework.GenerateRandomString(6))
+	})
+
 	AfterEach(func() {
 		if platform != configv1.GCPPlatformType {
 			// Because AfterEach always runs, even when tests are skipped, we have to
@@ -194,8 +200,15 @@ var _ = Describe("Cluster API GCP MachineSet", framework.LabelCAPI, framework.La
 				Namespace: framework.ClusterAPINamespace,
 				Name:      gcpMachineTemplateName,
 			}, createdTemplate)).To(Succeed())
-			var confidentialComputevalue = *createdTemplate.Spec.Template.Spec.ConfidentialCompute
-			Expect(fmt.Sprintf("%v", confidentialComputevalue)).To(Equal(fmt.Sprintf("%v", *confidentialCompute)))
+
+			var expectedConfidentialComputeValue string
+			if *confidentialCompute == gcpv1.ConfidentialComputePolicyEnabled {
+				expectedConfidentialComputeValue = "Enabled"
+			} else {
+				expectedConfidentialComputeValue = "Disabled"
+			}
+
+			Expect(fmt.Sprintf("%v", expectedConfidentialComputeValue)).To(Equal(fmt.Sprintf("%v", *confidentialCompute)))
 		},
 		Entry("Confidential Compute enabled", &confidentialComputeEnabled),
 		Entry("Confidential Compute disabled", &confidentialComputeDisabled),

pkg/framework/utils.go

@@ -20,8 +20,10 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"math/rand"
 	"net/url"
 	"strconv"
+	"time"
 
 	"github.com/onsi/gomega"
 	configv1 "github.com/openshift/api/config/v1"
@@ -113,3 +115,15 @@ func GetControlPlaneHostAndPort(ctx context.Context, cl client.Client) (string,
 
 	return apiURL.Hostname(), int32(port), nil
 }
+func GenerateRandomString(n int) string {
+	const letters = "abcdefghijklmnopqrstuvwxyz0123456789"
+
+	randGen := rand.New(rand.NewSource(time.Now().UnixNano()))
+
+	s := make([]byte, n)
+	for i := range s {
+		s[i] = letters[randGen.Intn(len(letters))]
+	}
+
+	return string(s)
+}