Skip to content

Commit 087bd03

Browse files
committed
Update latency profile observer, controller to fix problem where re-activating empty profile retained old config
Signed-off-by: Swarup Ghosh <[email protected]>
1 parent f221855 commit 087bd03

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

pkg/operator/configobservation/configobservercontroller/observe_config_controller.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,13 @@ func NewConfigObserver(
145145
network.ObserveServicesNodePortRange,
146146
nodeobserver.NewLatencyProfileObserver(
147147
node.LatencyConfigs,
148-
nodeobserver.NewSuppressConfigUpdateUntilSameProfileFunc(
149-
operatorClient,
150-
kubeInformersForNamespaces.ConfigMapLister().ConfigMaps(operatorclient.TargetNamespace),
151-
node.LatencyConfigs,
152-
),
148+
[]nodeobserver.ShouldSuppressConfigUpdatesFunc{
149+
nodeobserver.NewSuppressConfigUpdateUntilSameProfileFunc(
150+
operatorClient,
151+
kubeInformersForNamespaces.ConfigMapLister().ConfigMaps(operatorclient.TargetNamespace),
152+
node.LatencyConfigs,
153+
),
154+
},
153155
),
154156
proxy.NewProxyObserveFunc([]string{"targetconfigcontroller", "proxy"}),
155157
images.ObserveInternalRegistryHostname,

pkg/operator/starter.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
375375
latencyProfileController := latencyprofilecontroller.NewLatencyProfileController(
376376
operatorClient,
377377
operatorclient.TargetNamespace,
378-
node.LatencyConfigs,
378+
nil, // profile rejection logic is not required for this operator
379379
latencyprofilecontroller.NewInstallerRevisionConfigMatcher(
380380
kubeInformersForNamespaces.ConfigMapLister().ConfigMaps(operatorclient.TargetNamespace),
381381
node.LatencyConfigs,

0 commit comments

Comments
 (0)