Skip to content

Commit 27f0c3d

Browse files
committed
assets: disable btrfs collector in node-exporter
Profiling shows that node-exporter is using ~16% of CPU time on updating btrfs details. This FS is not included in RHEL kernels, so it can be safely disabled
1 parent 7b0a677 commit 27f0c3d

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Note: This CHANGELOG is only for the monitoring team to track all monitoring related changes. Please see OpenShift release notes for official changes.
22

3+
## 4.14
4+
5+
- [#1937](https://github.com/openshift/cluster-monitoring-operator/pull/1937) Disables btrfs collector
6+
37
## 4.13
48

59
- [#1785](https://github.com/openshift/cluster-monitoring-operator/pull/1785) Adds support for CollectionProfiles TechPreview

assets/node-exporter/daemonset.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ spec:
4040
- --collector.netdev.device-exclude=^(veth.*|[a-f0-9]{15}|enP.*|ovn-k8s-mp[0-9]*|br-ex|br-int|br-ext|br[0-9]*|tun[0-9]*|cali[a-f0-9]*)$
4141
- --collector.cpu.info
4242
- --collector.textfile.directory=/var/node_exporter/textfile
43+
- --no-collector.btrfs
4344
image: quay.io/prometheus/node-exporter:v1.5.0
4445
name: node-exporter
4546
resources:

jsonnet/components/node-exporter.libsonnet

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,12 @@ function(params)
207207
// gather that data (especially for bare metal clusters), and
208208
// add flags to collect the node_cpu_info metric + metrics
209209
// from the text file.
210+
// Disable btrfs collector as btrfs is not included in RHEL kernels
210211
args: [a for a in c.args if (a != '--no-collector.hwmon')] +
211212
[
212213
'--collector.cpu.info',
213214
'--collector.textfile.directory=' + textfileDir,
215+
'--no-collector.btrfs',
214216
],
215217
terminationMessagePolicy: 'FallbackToLogsOnError',
216218
volumeMounts+: [{

0 commit comments

Comments
 (0)