Set a degraded message when persistent storage is not configured

Author: fpetkovski

Diff for: CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 4.9
 
 - [#1241](https://github.com/openshift/cluster-monitoring-operator/pull/1241) Add config option to disable Grafana deployment.
+- [#1270](https://github.com/openshift/cluster-monitoring-operator/pull/1270) Show a message in the degraded condition when Platform Monitoring Prometheus runs without persistent storage. 
 
 ## 4.8
 

Diff for: pkg/client/status_reporter.go

@@ -62,7 +62,7 @@ func (r *StatusReporter) relatedObjects() []v1.ObjectReference {
 	}
 }
 
-func (r *StatusReporter) SetDone() error {
+func (r *StatusReporter) SetDone(degradedConditionMessage string) error {
 	co, err := r.client.Get(context.TODO(), r.clusterOperatorName, metav1.GetOptions{})
 	if apierrors.IsNotFound(err) {
 		co = r.newClusterOperator()
@@ -77,7 +77,7 @@ func (r *StatusReporter) SetDone() error {
 	conditions := newConditions(co.Status, r.version, time)
 	conditions.setCondition(v1.OperatorAvailable, v1.ConditionTrue, "Successfully rolled out the stack.", "RollOutDone", time)
 	conditions.setCondition(v1.OperatorProgressing, v1.ConditionFalse, "", "", time)
-	conditions.setCondition(v1.OperatorDegraded, v1.ConditionFalse, "", "", time)
+	conditions.setCondition(v1.OperatorDegraded, v1.ConditionFalse, degradedConditionMessage, "", time)
 	conditions.setCondition(v1.OperatorUpgradeable, v1.ConditionTrue, "", "", time)
 	co.Status.Conditions = conditions.entries()
 

Diff for: pkg/client/status_reporter_test.go

@@ -111,7 +111,7 @@ func TestStatusReporterSetDone(t *testing.T) {
 				w(mock)
 			}
 
-			got := sr.SetDone()
+			got := sr.SetDone("")
 
 			for _, check := range tc.check {
 				if err := check(mock, got); err != nil {

Diff for: pkg/manifests/config.go

@@ -38,6 +38,19 @@ type Config struct {
 	UserWorkloadConfiguration      *UserWorkloadConfiguration      `json:"-"`
 }
 
+func (c Config) IsStorageConfigured() bool  {
+	if c.ClusterMonitoringConfiguration == nil {
+		return false
+	}
+
+	prometheusK8sConfig := c.ClusterMonitoringConfiguration.PrometheusK8sConfig
+	if prometheusK8sConfig == nil {
+		return false
+	}
+
+	return prometheusK8sConfig.VolumeClaimTemplate != nil
+}
+
 type ClusterMonitoringConfiguration struct {
 	PrometheusOperatorConfig *PrometheusOperatorConfig    `json:"prometheusOperator"`
 	PrometheusK8sConfig      *PrometheusK8sConfig         `json:"prometheusK8s"`

Diff for: pkg/operator/operator.go

@@ -37,6 +37,8 @@ import (
 	"github.com/openshift/cluster-monitoring-operator/pkg/tasks"
 )
 
+const StorageNotConfiguredMessage = "Prometheus is running without persistent storage. Upgrades and cluster disruptions can lead to data loss."
+
 // InfrastructureConfig stores information about the cluster infrastructure
 // which is useful for the operator.
 type InfrastructureConfig struct {
@@ -480,8 +482,12 @@ func (o *Operator) sync(key string) error {
 		return err
 	}
 
+	var degradedConditionMessage string
+	if !config.IsStorageConfigured() {
+		degradedConditionMessage = StorageNotConfiguredMessage
+	}
 	klog.Info("Updating ClusterOperator status to done.")
-	err = o.client.StatusReporter().SetDone()
+	err = o.client.StatusReporter().SetDone(degradedConditionMessage)
 	if err != nil {
 		klog.Errorf("error occurred while setting status to done: %v", err)
 	}