Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-4057: Expose scrapeInterval setting for UWM Prometheus #2503

Merged
merged 1 commit into from
Nov 12, 2024
Merged

MON-4057: Expose scrapeInterval setting for UWM Prometheus #2503

merged 1 commit into from
Nov 12, 2024

Conversation

slashpai
Copy link
Member

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2024 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-4057 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@slashpai
Copy link
Member Author

/retest

simonpasquier
simonpasquier reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to validate the input value to be within acceptable boundaries (e.g. not too low and not too high).

@simonpasquier
Copy link
Contributor

/cc @eromanova97

if you want to check the updated documentation page.

@openshift-ci openshift-ci bot requested a review from eromanova97 October 22, 2024 13:36
eromanova97
eromanova97 reviewed Oct 23, 2024
View reviewed changes
@eromanova97
Copy link
Contributor

Added very small suggestions, thank you!

@slashpai
Copy link
Member Author

addressed review comments
@simonpasquier @eromanova97 PTAL

@slashpai slashpai force-pushed the scrapeInterval branch 2 times, most recently from fa309d6 to eef4533 Compare October 24, 2024 02:38
@slashpai
Copy link
Member Author

/skip

simonpasquier
simonpasquier reviewed Oct 24, 2024
View reviewed changes
machine424
machine424 reviewed Oct 24, 2024
View reviewed changes
@slashpai slashpai marked this pull request as draft November 7, 2024 05:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2024

Fixing one more thing

@slashpai slashpai marked this pull request as ready for review November 7, 2024 06:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@openshift-ci openshift-ci bot requested review from marioferh and rexagod November 7, 2024 06:40
@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2024

This is good for review again

@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2024

/test e2e-aws-ovn-techpreview

simonpasquier
simonpasquier reviewed Nov 7, 2024
View reviewed changes
@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2024

@simonpasquier @eromanova97 updated with changes

@slashpai
Copy link
Member Author

slashpai commented Nov 7, 2024

/skip

simonpasquier
simonpasquier reviewed Nov 8, 2024
View reviewed changes
@slashpai
MON-4057: Expose scrapeInterval setting for UWM Prometheus
b2f203f 
Allows to configure scrapeInterval between 5s and 5m
in `openshift-user-workload-monitoring/user-workload-monitoring-config`
configmap under `prometheus` field.

Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
Copy link
Member Author

@simonpasquier addressed comments PTAL

@slashpai
Copy link
Member Author

cc @juzhao

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@slashpai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node b2f203f link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@slashpai slashpai mentioned this pull request Nov 12, 2024
Merged
2 tasks
@juzhao
Copy link
Contributor

juzhao commented Nov 12, 2024

tested with PR, no issue
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2024 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-4057 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier
simonpasquier reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 07c95fb into openshift:master Nov 12, 2024
17 of 18 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.19.0-202411121041.p0.g07c95fb.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@machine424 machine424 machine424 left review comments

@eromanova97 eromanova97 eromanova97 left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

@marioferh marioferh Awaiting requested review from marioferh

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@slashpai @openshift-ci-robot @simonpasquier @eromanova97 @juzhao @openshift-bot @machine424