add console helm install metrics to gatherer function

Signed-off-by: Kartikey Mamgain <[email protected]>

Author: Kartikey-star

docs/gathered-data.md

@@ -511,6 +511,7 @@ Gathered metrics:
   cluster_installer
   vsphere_node_hw_version_total
   namespace CPU and memory usage
+  console_helm_installs_total
   followed by at most 1000 lines of ALERTS metric
 
 * Location in archive: config/metrics
@@ -524,6 +525,7 @@ Gathered metrics:
   - "namespace:container_memory_usage_bytes:sum": 4.5+
   - "virt_platform metric": 4.6.34+, 4.7.16+, 4.8+
   - "vsphere_node_hw_version_total": 4.7.11+, 4.8+
+  - "console_helm_installs_total": 4.8+
 
 
 ## MutatingWebhookConfigurations

pkg/gatherers/clusterconfig/clusterconfig_gatherer.go

@@ -79,7 +79,6 @@ var gatheringFunctions = map[string]gathererFuncPtr{
 	"image":                             (*Gatherer).GatherClusterImage,
 	"kube_controller_manager_logs":      (*Gatherer).GatherKubeControllerManagerLogs,
 	"overlapping_namespace_uids":        (*Gatherer).GatherNamespacesWithOverlappingUIDs,
-	"console_helm_installs_total":       (*Gatherer).GatherMetricsForHelmInstalls,
 }
 
 func New(

pkg/gatherers/clusterconfig/helm_metrics.go

@@ -30,6 +30,7 @@ const (
 //   cluster_installer
 //   vsphere_node_hw_version_total
 //   namespace CPU and memory usage
+//   console_helm_installs_total
 //   followed by at most 1000 lines of ALERTS metric
 //
 // * Location in archive: config/metrics
@@ -43,6 +44,7 @@ const (
 //   - "namespace:container_memory_usage_bytes:sum": 4.5+
 //   - "virt_platform metric": 4.6.34+, 4.7.16+, 4.8+
 //   - "vsphere_node_hw_version_total": 4.7.11+, 4.8+
+//   - "console_helm_installs_total": 4.8+
 func (g *Gatherer) GatherMostRecentMetrics(ctx context.Context) ([]record.Record, []error) {
 	metricsRESTClient, err := rest.RESTClientFor(g.metricsGatherKubeConfig)
 	if err != nil {
@@ -61,6 +63,7 @@ func gatherMostRecentMetrics(ctx context.Context, metricsClient rest.Interface)
 		Param("match[]", "namespace:container_memory_usage_bytes:sum").
 		Param("match[]", "vsphere_node_hw_version_total").
 		Param("match[]", "virt_platform").
+		Param("match[]", "console_helm_installs_total").
 		DoRaw(ctx)
 	if err != nil {
 		klog.Errorf("Unable to retrieve most recent metrics: %v", err)