openshift
diff --git a/‎.ci-operator.yaml
+1-1 b/‎.ci-operator.yaml
+1-1
diff --git a/‎.gitignore
+3 b/‎.gitignore
+3
diff --git a/‎CHANGELOG.md
+40-1 b/‎CHANGELOG.md
+40-1
diff --git a/‎Dockerfile
+2-2 b/‎Dockerfile
+2-2
diff --git a/‎Makefile
+1-1 b/‎Makefile
+1-1
diff --git a/‎README.md
+1 b/‎README.md
+1
diff --git a/‎cmd/changelog/main.go
+4-4 b/‎cmd/changelog/main.go
+4-4
diff --git a/‎cmd/gendoc/main.go
+33-33 b/‎cmd/gendoc/main.go
+33-33
diff --git a/‎docs/arch.md
+3-1 b/‎docs/arch.md
+3-1
@@ -1,4 +1,4 @@
 build_root_image:
   name: release
   namespace: openshift
-  tag: rhel-8-release-golang-1.19-openshift-4.13
+  tag: rhel-8-release-golang-1.19-openshift-4.14
@@ -10,3 +10,6 @@ devspace.yaml
 
 cover.out
 _output
+
+# MacOS
+.DS_Store
@@ -1,9 +1,48 @@
 # Note: This CHANGELOG is only for the changes in insights operator.
-	Please see OpenShift release notes for official changes\n<!--Latest hash: 76cc46b739c27281db0f7b2a23eb091b2a70f698-->
+	Please see OpenShift release notes for official changes\n<!--Latest hash: e761abf647746c56fb8c2a59fb683984795a0624-->
+## 4.14
+
+### Data Enhancement
+- [#741](https://github.com/openshift/insights-operator/pull/685) Gather openshift-monitoring persistent volumes
+
+### Others
+- [#756](https://github.com/openshift/insights-operator/pull/756) add unit tests for cluster proxy gatherer
+
 ## 4.13
 
+### Data Enhancement
+- [#726](https://github.com/openshift/insights-operator/pull/726) feat(recent_metrics) adds openshift_apps_deploymentconfigs_strategy_total
+- [#725](https://github.com/openshift/insights-operator/pull/725) Create gatherer for gathering machines.
+- [#714](https://github.com/openshift/insights-operator/pull/714) operators gatherer - handle ingresscontroller relatedObject & simplify
+
+### Bugfix
+- [#723](https://github.com/openshift/insights-operator/pull/723) Obfuscate HTTP_PROXY and HTTPS_PROXY env variables on containers
+- [#716](https://github.com/openshift/insights-operator/pull/716) additional fix
+- [#709](https://github.com/openshift/insights-operator/pull/709) do not periodically update Available clusteroperator co…
+- [#706](https://github.com/openshift/insights-operator/pull/706) do not get disabled rules
+- [#694](https://github.com/openshift/insights-operator/pull/694) Change of kube-system namespace configmap location according to docs. 
+- [#691](https://github.com/openshift/insights-operator/pull/691) storage/ceph path structure
+
 ### Others
+- [#728](https://github.com/openshift/insights-operator/pull/728) add unit test for silenced_alerts.go and rename it to gather_silenced_alerts.go
+- [#729](https://github.com/openshift/insights-operator/pull/729) add unit test for ingresses.go and rename it to gather_cluster_ingress.go 
+- [#738](https://github.com/openshift/insights-operator/pull/738) add unit test for oauth.go and rename it to gather_cluster_oauth.go 
+- [#735](https://github.com/openshift/insights-operator/pull/735) gather logs - update "FilterLogFromScanner" function and add some tests
+- [#733](https://github.com/openshift/insights-operator/pull/733) Add unit tests to openshift sdn controller logs gatherer
+- [#704](https://github.com/openshift/insights-operator/pull/704) update gathered documentation
+- [#721](https://github.com/openshift/insights-operator/pull/721) arch docs update - explain disabled=true status more
+- [#712](https://github.com/openshift/insights-operator/pull/712) Update operator name in the OWNERS file
+- [#702](https://github.com/openshift/insights-operator/pull/702) remove asset method and split tests
+- [#701](https://github.com/openshift/insights-operator/pull/701) move GatherSchedulerLogs to its own file
+- [#703](https://github.com/openshift/insights-operator/pull/703) chore(golanglint-ci) disabling some linters for *_test.go files
+- [#705](https://github.com/openshift/insights-operator/pull/705) Update OpenShift versions & new Download time field
+- [#692](https://github.com/openshift/insights-operator/pull/692) PR template preview and changelog update
 - [#693](https://github.com/openshift/insights-operator/pull/693) Use cgroups memory usage data in the archive metadata
+- [#733](https://github.com/openshift/insights-operator/pull/733) Renamed log gatherer file (SDN controller) and unit tests
+
+### Misc
+- [#717](https://github.com/openshift/insights-operator/pull/717) additional fix"
+- [#700](https://github.com/openshift/insights-operator/pull/700) Updating ose-insights-operator images to be consistent with ART
 
 ## 4.12
 
 
@@ -1,9 +1,9 @@
-FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.13 AS builder
+FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.14 AS builder
 WORKDIR /go/src/github.com/openshift/insights-operator
 COPY . .
 RUN make build
 
-FROM registry.ci.openshift.org/ocp/4.13:base
+FROM registry.ci.openshift.org/ocp/4.14:base
 COPY --from=builder /go/src/github.com/openshift/insights-operator/bin/insights-operator /usr/bin/
 COPY config/pod.yaml /etc/insights-operator/server.yaml
 COPY manifests /manifests
 
@@ -58,7 +58,7 @@ test: unit ## Run all the tests
 # Run the unit tests
 .PHONY: unit
 unit: ## Run the unit tests
-	go test $(GO_TEST_FLAGS) -coverprofile $(COVER_PROFILE) ./...
+	go test -race $(GO_TEST_FLAGS) -coverprofile $(COVER_PROFILE) ./...
 
 .PHONY: coverage
 coverage:
 
@@ -4,6 +4,7 @@ This cluster operator gathers anonymized system configuration and reports it to
 standard OpenShift distribution. The data collected allows for debugging in the event of cluster failures or
 unanticipated errors.
 
+
 # Table of Contents
 
 - [Insights Operator](#insights-operator)
 
@@ -206,14 +206,14 @@ func createCHANGELOG(releaseBlocks map[ReleaseVersion]MarkdownReleaseBlock) {
 	defer file.Close()
 	_, _ = file.WriteString(`# Note: This CHANGELOG is only for the changes in insights operator.
 	Please see OpenShift release notes for official changes\n`)
-	_, _ = file.WriteString(fmt.Sprintf("<!--Latest hash: %s-->\n", latestHash))
+	_, _ = fmt.Fprintf(file, "<!--Latest hash: %s-->\n", latestHash)
 	var releases ReleaseVersions
 	for k := range releaseBlocks {
 		releases = append(releases, k)
 	}
 	sort.Sort(sort.Reverse(releases))
 	for _, release := range releases {
-		_, _ = file.WriteString(fmt.Sprintf("## %d.%d\n\n", release.Major, release.Minor))
+		_, _ = fmt.Fprintf(file, "## %d.%d\n\n", release.Major, release.Minor)
 
 		dataEnhancements := releaseBlocks[release].dataEnhancements
 		createReleaseBlock(file, dataEnhancements, DATAENHANCEMENT)
@@ -234,8 +234,8 @@ func createCHANGELOG(releaseBlocks map[ReleaseVersion]MarkdownReleaseBlock) {
 
 func createReleaseBlock(file *os.File, release, title string) {
 	if len(release) > 0 {
-		_, _ = file.WriteString(fmt.Sprintf("### %s\n", title))
-		_, _ = file.WriteString(fmt.Sprintf("%s\n", release))
+		_, _ = fmt.Fprintf(file, "### %s\n", title)
+		_, _ = fmt.Fprintf(file, "%s\n", release)
 	}
 }
 
 
@@ -18,12 +18,13 @@ import (
 )
 
 var (
-	inPath     string
-	outPath    string
-	mdf        *os.File
-	randSource = rand.NewSource(time.Now().UnixNano())
-	reGather   = regexp.MustCompile(`^((Build)?Gather)(.*)`)
-	reExample  = regexp.MustCompile(`^(Example)(.*)`)
+	inPath          string
+	outPath         string
+	mdf             *os.File
+	randSource      = rand.NewSource(time.Now().UnixNano())
+	reGather        = regexp.MustCompile(`^((Build)?Gather)(.*)`)
+	reExample       = regexp.MustCompile(`^(Example)(.*)`)
+	reSampleArchive = regexp.MustCompile(`docs/(insights-archive-sample/.*)`)
 )
 
 type DocBlock struct {
@@ -50,7 +51,7 @@ func main() {
 	if err != nil {
 		fmt.Print(err)
 	}
-	// second pass will gather Sample..
+	// second pass will gather Sample...
 	err = walkDir(cleanRoot, md)
 	if err != nil {
 		fmt.Print(err)
@@ -76,9 +77,9 @@ func main() {
 		fmt.Print(err)
 	}
 	for _, k := range keys {
-		_, err = mdf.WriteString(fmt.Sprintf(
+		_, err := fmt.Fprintf(mdf,
 			"## %s\n\n"+
-				"%s\n\n", k, md[k].Doc))
+				"%s\n\n", k, md[k].Doc)
 		if err != nil {
 			fmt.Print(err)
 		}
@@ -89,16 +90,16 @@ func main() {
 				size = len(e)
 			}
 			size /= len(md[k].Examples)
-			_, err := mdf.WriteString(fmt.Sprintf(
+			_, err := fmt.Fprintf(mdf,
 				"Output raw size: %d\n\n"+
-					"### Examples\n\n", size))
+					"### Examples\n\n", size)
 			if err != nil {
 				fmt.Print(err)
 			}
 			for n, e := range md[k].Examples {
-				_, err := mdf.WriteString(fmt.Sprintf(
+				_, err := fmt.Fprintf(mdf,
 					"#### %s\n"+
-						"```%s```\n\n", n, e))
+						"```%s```\n\n", n, e)
 				if err != nil {
 					fmt.Print(err)
 				}
@@ -263,23 +264,22 @@ func mustGetPackageName(astRoot string, f *ast.Package) string {
 	}
 	if firstKey == "" {
 		log.Fatalf("Package %q is composed of %d source files", f.Name, len(f.Files))
-	} else {
-		pkgAbs, err := filepath.Abs(filepath.Join(astRoot, filepath.Dir(firstKey)))
-		if err != nil {
-			log.Fatal(err)
-		}
-		goModPath, relPkgPath, err := findGoMod(pkgAbs)
-		if err != nil {
-			log.Fatal(err)
-		}
-		moduleName, err := getModuleNameFromGoMod(goModPath)
-		if err != nil {
-			log.Fatal(err)
-		}
-		importPath := filepath.Join(moduleName, relPkgPath)
-		return importPath
 	}
-	return ""
+
+	pkgAbs, err := filepath.Abs(filepath.Join(astRoot, filepath.Dir(firstKey)))
+	if err != nil {
+		log.Fatal(err)
+	}
+	goModPath, relPkgPath, err := findGoMod(pkgAbs)
+	if err != nil {
+		log.Fatal(err)
+	}
+	moduleName, err := getModuleNameFromGoMod(goModPath)
+	if err != nil {
+		log.Fatal(err)
+	}
+	importPath := filepath.Join(moduleName, relPkgPath)
+	return importPath
 }
 
 // execExampleMethod executes the method by starting go run and capturing the produced standard output
@@ -298,16 +298,15 @@ func execExampleMethod(methodFullPackage, methodPackage, methodName string) (str
 			fmt.Print(err)
 		}
 	}()
-
-	_, err = tf.WriteString(fmt.Sprintf(`package main
+	_, err = fmt.Fprintf(tf, `package main
 	import "%s"
 	import "fmt"
 
 	func main() {
 		str, _ := %s.%s()
 		fmt.Print(str)
 	}
-		`, methodFullPackage, methodPackage, methodName))
+		`, methodFullPackage, methodPackage, methodName)
 	if err != nil {
 		fmt.Print(err)
 	}
@@ -337,7 +336,8 @@ func parseDoc(method, doc string) *DocBlock {
 		doc = strings.TrimLeft(doc, method)
 	}
 	doc = strings.TrimLeft(doc, " ")
-
+	// generates the link to the sample archive
+	doc = reSampleArchive.ReplaceAllString(doc, "[$0](./$1)")
 	db := &DocBlock{Doc: doc}
 	return db
 }
@@ -244,7 +244,9 @@ oc get co insights -o=json | jq '.status.conditions'
 A condition is defined by its type. You may notice that there are some non-standard clusteroperator conditions. They are:
 - `SCAAvailable` - based on the SCA (Simple Content Access) controller in `pkg/ocm/sca/sca.go` and provides information about the status of downloading the SCA entitlements.
 - `ClusterTransferAvailable` - based on the cluster transfer controller in `pkg/ocm/clustertransfer/cluster_transfer.go` and provides information about the availability of cluster transfers.
-- `Disabled` - indicates whether data gathering is disabled or enabled.
+- `Disabled` - indicates whether data gathering is disabled or enabled. Note that when the operator is `Disabled=True`, it is still also `Available=True`, which is strange at first glance, but the Cluster Version Operator (CVO) checks that all the clusteroperators are `Available=True` during the OpenShift installation. If they are not, the installation will fail, which happens in disconnected environments/clusters where the Insights operator is usually `Disabled=True` (because there is no `cloud.openshift.com` token in the `pull-secret`). You can find more about this topic in:
+  - https://pkg.go.dev/github.com/openshift/api/config/v1#ClusterStatusConditionType - note that when the Insights Operator is `Disabled=True` then it does not require immediate administrator intervention (and thus it still reports `Available=True`) - i.e nobody should be paged in this situation
+  - https://github.com/openshift/enhancements/blob/master/dev-guide/cluster-version-operator/dev/clusteroperator.md#conditions
 
 In addition to the above clusteroperator conditions, there are some intermediate clusteroperator conditions. These are:
 - `UploadDegraded` - this condition occurs when there is any unsuccessful upload of the Insights data (if the number of the upload attemp is equal or greater than 5 then the operator is marked as **Degraded**). Example is: