Skip to content

Commit 3dcb003

Browse files
Merge pull request #7467 from mkowalski/OCPBUGS-18428
OCPBUGS-18428: Add ip=dhcp,dhcp6 kernel param for vSphere dual-stack
2 parents 32302a8 + 6db25a8 commit 3dcb003

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/asset/machines/master.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,8 @@ func (m *Master) Generate(dependencies asset.Parents) error {
557557
// The maximum number of networks supported on ServiceNetwork is two, one IPv4 and one IPv6 network.
558558
// The cluster-network-operator handles the validation of this field.
559559
// Reference: https://github.com/openshift/cluster-network-operator/blob/fc3e0e25b4cfa43e14122bdcdd6d7f2585017d75/pkg/network/cluster_config.go#L45-L52
560-
if ic.Platform.Name() == openstacktypes.Name && len(installConfig.Config.ServiceNetwork) == 2 {
560+
if ic.Networking != nil && len(ic.Networking.ServiceNetwork) == 2 &&
561+
(ic.Platform.Name() == openstacktypes.Name || ic.Platform.Name() == vspheretypes.Name) {
561562
// Only configure kernel args for dual-stack clusters.
562563
ignIPv6, err := machineconfig.ForDualStackAddresses("master")
563564
if err != nil {

pkg/asset/machines/worker.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,8 @@ func (w *Worker) Generate(dependencies asset.Parents) error {
298298
// The maximum number of networks supported on ServiceNetwork is two, one IPv4 and one IPv6 network.
299299
// The cluster-network-operator handles the validation of this field.
300300
// Reference: https://github.com/openshift/cluster-network-operator/blob/fc3e0e25b4cfa43e14122bdcdd6d7f2585017d75/pkg/network/cluster_config.go#L45-L52
301-
if ic.Platform.Name() == openstacktypes.Name && len(installConfig.Config.ServiceNetwork) == 2 {
301+
if ic.Networking != nil && len(ic.Networking.ServiceNetwork) == 2 &&
302+
(ic.Platform.Name() == openstacktypes.Name || ic.Platform.Name() == vspheretypes.Name) {
302303
// Only configure kernel args for dual-stack clusters.
303304
ignIPv6, err := machineconfig.ForDualStackAddresses("worker")
304305
if err != nil {

0 commit comments

Comments
 (0)