Skip to content

Commit 09d7325

Browse files
danwinshipbertinatto
authored andcommitted
UPSTREAM: <carry>: Revert "Remove Endpoints write access from aggregated edit role"
OpenShift has an admission controller to prevent restricted Endpoints changes, and there's no reason to block non-restricted changes (such as modifying the annotations of an Endpoints, which is done by "oc idle"). This reverts commit 416efda. OpenShift-Rebase-Source: 239b9ed
1 parent 665b08f commit 09d7325

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ func clusterRoles() []rbacv1.ClusterRole {
325325
rbacv1helpers.NewRule(Write...).Groups(legacyGroup).Resources("pods", "pods/attach", "pods/proxy", "pods/exec", "pods/portforward").RuleOrDie(),
326326
rbacv1helpers.NewRule("create").Groups(legacyGroup).Resources("pods/eviction").RuleOrDie(),
327327
rbacv1helpers.NewRule(Write...).Groups(legacyGroup).Resources("replicationcontrollers", "replicationcontrollers/scale", "serviceaccounts",
328-
"services", "services/proxy", "persistentvolumeclaims", "configmaps", "secrets", "events").RuleOrDie(),
328+
"services", "services/proxy", "endpoints", "persistentvolumeclaims", "configmaps", "secrets", "events").RuleOrDie(),
329329
rbacv1helpers.NewRule("create").Groups(legacyGroup).Resources("serviceaccounts/token").RuleOrDie(),
330330

331331
rbacv1helpers.NewRule(Write...).Groups(appsGroup).Resources(

plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/cluster-roles.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ items:
134134
- ""
135135
resources:
136136
- configmaps
137+
- endpoints
137138
- events
138139
- persistentvolumeclaims
139140
- replicationcontrollers

0 commit comments

Comments
 (0)