Skip to content

Commit 2d05c38

Browse files
committed
DRA E2E: fix "cluster must manage ResourceSlices" test
Adding SharedCounters broke the test and wasn't detected in the presubmit because the test is slow and didn't run. We could add a "SharedCounters is empty" clause, but probably it is safer to be less strict in the test and tolerate unknown fields. This will also minimize the work which needs to be done in the v1beta2 PR.
1 parent 473533a commit 2d05c38

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/e2e/dra/dra.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -1776,7 +1776,9 @@ var _ = framework.SIGDescribe("node")("DRA", feature.DynamicResourceAllocation,
17761776
}),
17771777
),
17781778
}),
1779-
"Spec": gstruct.MatchAllFields(gstruct.Fields{
1779+
// Ignoring some fields, like SharedCounters, because we don't run this test
1780+
// for PRs (it's slow) and don't want CI breaks when fields get added or renamed.
1781+
"Spec": gstruct.MatchFields(gstruct.IgnoreExtras, gstruct.Fields{
17801782
"Driver": gomega.Equal(driver.Name),
17811783
"NodeName": gomega.Equal(nodeName),
17821784
"NodeSelector": gomega.BeNil(),

0 commit comments

Comments
 (0)