Skip to content

Commit 2e0cc1b

Browse files
authored
Merge pull request kubernetes#127943 from ii/promote-serviceaccounttoken-test
Promote ServiceAccount e2e test to Conformance
2 parents 8fe10dc + 04a4edb commit 2e0cc1b

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

Diff for: test/conformance/testdata/conformance.yaml

+8
Original file line numberDiff line numberDiff line change
@@ -1339,6 +1339,14 @@
13391339
and 3c the ServiceTokenVolume MUST not be auto mounted.
13401340
release: v1.9
13411341
file: test/e2e/auth/service_accounts.go
1342+
- testname: ServiceAccount, create and review token
1343+
codename: '[sig-auth] ServiceAccounts should create a serviceAccountToken and ensure
1344+
a successful TokenReview [Conformance]'
1345+
description: Creating a ServiceAccount MUST succeed. Creating a ServiceAccountToken
1346+
MUST succeed. The token MUST not be empty. Creating a TokenReview MUST succeed.
1347+
The TokenReview MUST be authenticated without any errors.
1348+
release: v1.32
1349+
file: test/e2e/auth/service_accounts.go
13421350
- testname: RootCA ConfigMap test
13431351
codename: '[sig-auth] ServiceAccounts should guarantee kube-root-ca.crt exist in
13441352
any namespace [Conformance]'

Diff for: test/e2e/auth/service_accounts.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -868,7 +868,14 @@ var _ = SIGDescribe("ServiceAccounts", func() {
868868
framework.Logf("AutomountServiceAccountToken: %v", *updatedServiceAccount.AutomountServiceAccountToken)
869869
})
870870

871-
ginkgo.It("should create a serviceAccountToken and ensure a successful TokenReview", func(ctx context.Context) {
871+
/*
872+
Release: v1.32
873+
Testname: ServiceAccount, create and review token
874+
Description: Creating a ServiceAccount MUST succeed. Creating a ServiceAccountToken
875+
MUST succeed. The token MUST not be empty. Creating a TokenReview MUST succeed.
876+
The TokenReview MUST be authenticated without any errors.
877+
*/
878+
framework.ConformanceIt("should create a serviceAccountToken and ensure a successful TokenReview", func(ctx context.Context) {
872879
ns := f.Namespace.Name
873880
saClient := f.ClientSet.CoreV1().ServiceAccounts(ns)
874881
saName := "e2e-sa-" + utilrand.String(5)

0 commit comments

Comments
 (0)