Skip to content

Commit df2b918

Browse files
deads2kironcladlou
authored andcommitted
UPSTREAM: 49219: Use case-insensitive header keys for --requestheader-group-headers.
:100644 100644 3c34db6... 38f132b... M staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader.go :100644 100644 33e5afc... d81d4ee... M staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader_test.go
1 parent b531385 commit df2b918

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ func headerValue(h http.Header, headerNames []string) string {
145145
func allHeaderValues(h http.Header, headerNames []string) []string {
146146
ret := []string{}
147147
for _, headerName := range headerNames {
148-
values, ok := h[headerName]
148+
headerKey := http.CanonicalHeaderKey(headerName)
149+
values, ok := h[headerKey]
149150
if !ok {
150151
continue
151152
}

staging/src/k8s.io/apiserver/pkg/authentication/request/headerrequest/requestheader_test.go

+14
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,20 @@ func TestRequestHeader(t *testing.T) {
111111
},
112112
expectedOk: true,
113113
},
114+
"groups case-insensitive": {
115+
nameHeaders: []string{"X-REMOTE-User"},
116+
groupHeaders: []string{"X-REMOTE-Group"},
117+
requestHeaders: http.Header{
118+
"X-Remote-User": {"Bob"},
119+
"X-Remote-Group": {"Users"},
120+
},
121+
expectedUser: &user.DefaultInfo{
122+
Name: "Bob",
123+
Groups: []string{"Users"},
124+
Extra: map[string][]string{},
125+
},
126+
expectedOk: true,
127+
},
114128

115129
"extra prefix matches case-insensitive": {
116130
nameHeaders: []string{"X-Remote-User"},

0 commit comments

Comments
 (0)