Skip to content

Commit 1a18bbf

Browse files
Remove BSL NS Ref, just use name
1 parent c8affd4 commit 1a18bbf

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

docs/design/data-protection-test.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,15 @@ This design addresses that need by measuring:
3737
- Integration via DPA CR
3838

3939
## High-Level Design
40+
41+
This controller and CRD will be part of OADP Operator. The controller will be part of the OADP controller manager pod, there won't be a separate pod.
42+
4043
Components involved and their responsibilities:
4144

4245
- **DataProtectionTest (DPT) CRD:**
4346
- **Spec:**
4447
- **backupLocationSpec:** Contains Velero-based backup storage configuration.
45-
- **backupLocationRef:** Contains the Name and Namespace reference for Velero BSL
48+
- **backupLocationName:** Name of Velero BSL to be used
4649
- **uploadSpeedTestConfig:** Test parameters for the upload (file size, test timeout).
4750
- **CSIVolumeSnapshotTestConfig:** Test parameters for the CSI VolumeSnapshot test (snapshot class, source PVC name and namespace for each PVC, plus snapshot timeout).
4851
- **Status:**
@@ -51,7 +54,8 @@ Components involved and their responsibilities:
5154
- **S3Vendor:** Reports the detected S3 vendor string from vendor determination. (This is only applicable for S3-compatible object storage providers)
5255
- **BucketMetadata:** Reports the encryptionAlgorithm used for the bucket as well as the versioningStatus.
5356

54-
**Note:** Either `backupLocationSpec` or `backupLocationRef` will be processed for a particular DPT instance, if both are specified DPT would error out.
57+
**Note:** Either `backupLocationSpec` or `backupLocationName` will be processed for a particular DPT instance, if both are specified DPT would error out.
58+
5559
- **DataProtectionTest Controller:**
5660
- Monitors DataProtectionTest CRs.
5761
- Extracts configuration from the backup location spec.
@@ -65,6 +69,8 @@ Components involved and their responsibilities:
6569
- AWS-specific implementation (S3Provider) is provided using the AWS SDK.
6670
- **Vendor Determination Logic:**
6771
- A helper function performs an HTTP HEAD call to the **s3Url** and inspects headers (especially the `Server` header) to determine the vendor (e.g., "AWS", "MinIO", etc.).
72+
- **Bucket Metadata Retrieval:**
73+
- The DPT controller retrieves encryption and versioning configuration for the target object storage bucket using the cloud provider SDK.
6874

6975
## Detailed Design
7076

@@ -78,9 +84,7 @@ kind: DataProtectionTest
7884
metadata:
7985
name: my-data-protection-test
8086
spec:
81-
backupLocationRef: # optional, either this or backupLocationSpec
82-
name: aws-bsl
83-
namespace: openshift-adp
87+
backupLocationName: aws-bsl # optional, either this or backupLocationSpec
8488
backupLocationSpec:
8589
provider: aws # Cloud provider type (aws, azure, gcp)
8690
default: true

0 commit comments

Comments
 (0)