Skip to content

Commit 6c71d18

Browse files
committed
Adding first past of peer review comments
1 parent f85b059 commit 6c71d18

2 files changed

+10
-10
lines changed

modules/nw-metallb-operator-setting-pod-priority-affinity.adoc

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,26 @@
77

88
You can optionally assign pod priority and pod affinity rules to `controller` and `speaker` pods by configuring the `MetalLB` custom resource. The pod priority indicates the relative importance of a pod on a node and schedules the pod based on this priority. Set a high priority on your `controller` or `speaker` pod to ensure scheduling priority over other pods on the node.
99

10-
Pod affinity manages relationships among pods. Assign pod affinity to the `controller` or `speaker` pods to control on what node the scheduler places the pod in the context of pod relationships. For example, using pod affinity rules, you can ensure that these pods are co-located on the same nodes or nodes. This can help optimize network communication and reduce latency between these components.
10+
Pod affinity manages relationships among pods. Assign pod affinity to the `controller` or `speaker` pods to control on what node the scheduler places the pod in the context of pod relationships. For example, you can use pod affinity rules to ensure that certain pods are located on the same node or nodes, which can help improve network communication and reduce latency between those components.
1111

1212
.Prerequisites
1313

1414
* You are logged in as a user with `cluster-admin` privileges.
1515

1616
* You have installed the MetalLB Operator.
1717

18-
* You have started MetalLB on your cluster.
18+
* You have started the MetalLB Operator on your cluster.
1919

2020
.Procedure
21-
. Create a `PriorityClass` custom resource, such as `myPriorityClass.yaml`, to configure the priority level. This example defines a `PriorityClass` named `high-priority` with a value of `1000000`. Pods that are assigned this priority class will be considered higher-priority during scheduling compared to pods with lower priority classes:
21+
. Create a `PriorityClass` custom resource, such as `myPriorityClass.yaml`, to configure the priority level. This example defines a `PriorityClass` named `high-priority` with a value of `1000000`. Pods that are assigned this priority class are considered higher priority during scheduling compared to pods with lower priority classes:
2222
+
2323
[source,yaml]
2424
----
2525
apiVersion: scheduling.k8s.io/v1
2626
kind: PriorityClass
2727
metadata:
28-
name: high-priority <1>
29-
value: 1000000 <2>
28+
name: high-priority
29+
value: 1000000
3030
----
3131

3232
. Apply the `PriorityClass` custom resource configuration:
@@ -68,7 +68,7 @@ spec:
6868
----
6969
+
7070
<1> Specifies the priority class for the MetalLB controller pods. In this case, it is set to `high-priority`.
71-
<2> Specifies that you are configuring pod affinity rules. These rules dictate how pods are scheduled in relation to other pods or nodes. This configuration instructs the scheduler to schedule pods that have the label `app: metallb` onto nodes that share the same hostname. This helps to colocate MetalLB-related pods on the same nodes, potentially optimizing network communication, latency, and resource usage between these pods.
71+
<2> Specifies that you are configuring pod affinity rules. These rules dictate how pods are scheduled in relation to other pods or nodes. This configuration instructs the scheduler to schedule pods that have the label `app: metallb` onto nodes that share the same hostname. This helps to co-locate MetalLB-related pods on the same nodes, potentially optimizing network communication, latency, and resource usage between these pods.
7272

7373
. Apply the `MetalLB` custom resource configuration:
7474
+
@@ -78,7 +78,7 @@ $ oc apply -f MetalLBPodConfig.yaml
7878
----
7979

8080
.Verification
81-
* To view the priority class that you assigned to pods in the metallb-system namespace, run the following command:
81+
* To view the priority class that you assigned to pods in the `metallb-system` namespace, run the following command:
8282
+
8383
[source,bash]
8484
----
@@ -96,7 +96,7 @@ metallb-operator-webhook-server-c895594d4-shjgx <none>
9696
speaker-dddf7 high-priority
9797
----
9898

99-
* To verify that the scheduler placed pods according to pod affinity rules, view the metadata for the pod's node by running the following command:
99+
* To verify that the scheduler placed pods according to pod affinity rules, view the metadata for the pod's node or nodes by running the following command:
100100
+
101101
[source,bash]
102102
----

modules/nw-metallb-operator-setting-runtimeclass.adoc

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
[id="nw-metallb-operator-setting-runtimeclass_{context}"]
66
= Configuring a container runtime class in a MetalLB deployment
77

8-
You can optionally assign a container runtime class to `controller` and `speaker` pods by configuring the `MetalLB` custom resource. For example, for Windows workloads, you can assign a Windows runtime class to the pod, which uses this runtime class for all containers in the pod.
8+
You can optionally assign a container runtime class to `controller` and `speaker` pods by configuring the MetalLB custom resource. For example, for Windows workloads, you can assign a Windows runtime class to the pod, which uses this runtime class for all containers in the pod.
99

1010
.Prerequisites
1111

@@ -52,7 +52,7 @@ spec:
5252
annotations: <1>
5353
speaker: demo
5454
----
55-
<1> This example uses `annotations` to add metadata such as build release information or GitHub pull request information. You can populate annotations with characters not permitted in labels. However, you cannot use annotations to identify or select objects.
55+
<1> The earlier example uses `annotations` to add metadata such as build release information or GitHub pull request information. You can populate annotations with characters that are no permitted in labels. However, you cannot use annotations to identify or select objects.
5656

5757
. Apply the `MetalLB` custom resource configuration:
5858
+

0 commit comments

Comments
 (0)