Skip to content

Commit cb71387

Browse files
authored
Merge pull request #3165 from jim-minter/bz1373330
Document warnings returned by generic buildhook
2 parents 429f881 + dfebe20 commit cb71387

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

dev_guide/builds.adoc

+11-1
Original file line numberDiff line numberDiff line change
@@ -1770,6 +1770,16 @@ and a payload. The `-H` argument sets the *Content-Type* header to
17701770
The `--data-binary` argument is used to send a binary payload with newlines
17711771
intact with the `*POST*` request.
17721772

1773+
[NOTE]
1774+
====
1775+
{product-title} will permit builds to be triggered via the generic webhook even
1776+
if an invalid request payload is presented (e.g. invalid content-type,
1777+
unparseable or invalid content, etc.). This behaviour is maintained for
1778+
backwards compatibility reasons. In the case that an invalid request payload is
1779+
presented, {product-title} returns a warning in JSON format as part of its HTTP
1780+
200 OK response.
1781+
====
1782+
17731783
[[describe-buildconfig]]
17741784

17751785
*Displaying a BuildConfig's Webhook URLs*
@@ -2558,7 +2568,7 @@ The `*nodeSelector*` value can also be controlled by cluster-wide default and
25582568
override values. Defaults will only be applied if the build configuration does
25592569
not define any key/value pairs for the `*nodeSelector*` and also does not define
25602570
an explicitly empty map value of "nodeSelector:{}". Override values will replace
2561-
values in the build configuration on a key by key basis.
2571+
values in the build configuration on a key by key basis.
25622572

25632573
ifdef::openshift-enterprise,openshift-origin[]
25642574
See xref:../install_config/build_defaults_overrides.adoc#overview[configuring

0 commit comments

Comments
 (0)