Skip to content

Commit d888b77

Browse files
committed
Note clarifications (squash)
1 parent de342de commit d888b77

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

modules/ossm-automatic-sidecar-injection.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ oc get deployment -n bookinfo ratings-v1 -o yaml
3030
----
3131
+
3232
. Open the application's Deployment YAML file in an editor.
33-
// 04/24/2024: spec.template.metadata might need to say metadata.labels. instead of metadata.annotations, pending confirmation from dev
33+
3434
. Add `spec.template.metadata.labels.sidecar.istio/inject` to your Deployment YAML file and set `sidecar.istio.io/inject` to `true` as shown in the following example.
3535
+
3636
.Example snippet from bookinfo deployment-ratings-v1.yaml
@@ -53,7 +53,7 @@ spec:
5353
+
5454
[NOTE]
5555
====
56-
Use `label` instead of `annotation`.
56+
Using the `annotations` parameter when enabling automatic sidecar injection is deprecated and is replaced by using the `labels` parameter.
5757
====
5858
+
5959
. Save the Deployment YAML file.

0 commit comments

Comments
 (0)