Skip to content

Commit 3e1e9be

Browse files
UPSTREAM: <carry>: [Default Catalog Consistency Test]: fix junit output format to allow generate xml
1 parent 524ecb6 commit 3e1e9be

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Binaries for programs and plugins
2+
bin/*

openshift/default-catalog-consistency/Makefile

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,26 @@ help: #HELP Display essential help.
2323

2424
#SECTION Tests
2525

26+
# Set the Ginkgo binary path. Assumes it's installed via `go install`
27+
GOBIN ?= $(shell go env GOBIN)
28+
ifeq ($(GOBIN),)
29+
GOBIN := $(shell go env GOPATH)/bin
30+
endif
31+
32+
TOOLS_BIN_DIR := $(CURDIR)/bin
33+
GINKGO := $(TOOLS_BIN_DIR)/ginkgo
34+
35+
.PHONY: install-tools
36+
install-tools: $(GINKGO) #HELP Build vendored CLI tools
37+
38+
$(GINKGO): vendor/modules.txt
39+
go build -mod=vendor -o $(GINKGO) ./vendor/github.com/onsi/ginkgo/v2/ginkgo
40+
2641
.PHONY: test-catalog
27-
test-catalog: #HELP Run the set of tests to validate the quality of catalogs
28-
E2E_GINKGO_OPTS="$(if $(ARTIFACT_DIR),--output-dir='$(ARTIFACT_DIR)') --junit-report junit_e2e.xml" \
29-
go test -count=1 -v ./test/validate/...;
42+
test-catalog: install-tools $(GINKGO) #HELP Run the set of tests to validate the quality of catalogs
43+
$(GINKGO) $(if $(ARTIFACT_DIR),--output-dir='$(ARTIFACT_DIR)') \
44+
--junit-report=junit_olm.xml ./test/validate/...
45+
3046

3147
#SECTION Development
3248

0 commit comments

Comments
 (0)