disambiguate kinds on other resources by showing group

Author: benjaminapetersen

Diff for: app/scripts/controllers/otherResources.js

@@ -57,6 +57,20 @@ angular.module('openshiftConsole')
       }).toString();
     };
 
+    var countKinds = function() {
+      return _.countBy($scope.kinds, function(kind) {
+        return kind.kind;
+      });
+    };
+
+    var counts;
+    $scope.isDuplicateKind = function(kind) {
+      if(!counts) {
+        counts = countKinds();
+      }
+      return counts[kind] > 1;
+    };
+
     // get and clear any alerts
     AlertMessageService.getAlerts().forEach(function(alert) {
       $scope.alerts[alert.name] = alert.data;

Diff for: app/views/other-resources.html

@@ -14,6 +14,7 @@ <h1>Other Resources</h1>
               <ui-select-match placeholder="Choose a resource to list...">{{$select.selected.kind | humanizeKind : true}}</ui-select-match>
               <ui-select-choices repeat="kind in kinds | filter : {kind: $select.search} : matchKind | orderBy : 'kind'">
                 <div ng-bind-html="(kind.kind | humanizeKind : true) | highlight: $select.search"></div>
+                <small ng-if="isDuplicateKind(kind.kind)" ng-bind-html="kind.group | highlight: $select.search" class="text-muted"></small>
               </ui-select-choices>
             </ui-select>
             <div class="vertical-divider"></div>

Diff for: dist/scripts/scripts.js

@@ -7478,10 +7478,18 @@ projectName:a.project,
 kind:b,
 group:_.get(c, "kindSelector.selected.group", "")
 }).toString() :"";
+};
+var n, o = function() {
+return _.countBy(c.kinds, function(a) {
+return a.kind;
+});
+};
+c.isDuplicateKind = function(a) {
+return n || (n = o()), n[a] > 1;
 }, d.getAlerts().forEach(function(a) {
 c.alerts[a.name] = a.data;
 }), d.clearAlerts();
-var n = function(a, b) {
+var p = function(a, b) {
 return _.some(c.kinds, function(c) {
 return c.kind === a && (!c.group && !b || c.group === b);
 });
@@ -7493,13 +7501,13 @@ resource:k.kindToResource(a.kind),
 group:a.group || ""
 };
 return !!e.checkResource(b.resource) && e.canI(b, "list", c.projectName);
-}), c.project = b, c.context = d, c.kindSelector.disabled = !1, a.kind && n(a.kind, a.group) && (_.set(c, "kindSelector.selected.kind", a.kind), _.set(c, "kindSelector.selected.group", a.group || ""));
+}), c.project = b, c.context = d, c.kindSelector.disabled = !1, a.kind && p(a.kind, a.group) && (_.set(c, "kindSelector.selected.kind", a.kind), _.set(c, "kindSelector.selected.group", a.group || ""));
 })), c.loadKind = m, c.$watch("kindSelector.selected", function() {
 c.alerts = {}, m();
 });
-var o = h("humanizeKind");
+var q = h("humanizeKind");
 c.matchKind = function(a, b) {
-return o(a).toLowerCase().indexOf(b.toLowerCase()) !== -1;
+return q(a).toLowerCase().indexOf(b.toLowerCase()) !== -1;
 }, i.onActiveFiltersChanged(function(a) {
 c.$apply(function() {
 c.resources = a.select(c.unfilteredResources), l();

Diff for: dist/scripts/templates.js

@@ -11666,6 +11666,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<ui-select-match placeholder=\"Choose a resource to list...\">{{$select.selected.kind | humanizeKind : true}}</ui-select-match>\n" +
     "<ui-select-choices repeat=\"kind in kinds | filter : {kind: $select.search} : matchKind | orderBy : 'kind'\">\n" +
     "<div ng-bind-html=\"(kind.kind | humanizeKind : true) | highlight: $select.search\"></div>\n" +
+    "<small ng-if=\"isDuplicateKind(kind.kind)\" ng-bind-html=\"kind.group | highlight: $select.search\" class=\"text-muted\"></small>\n" +
     "</ui-select-choices>\n" +
     "</ui-select>\n" +
     "<div class=\"vertical-divider\"></div>\n" +

Diff for: dist/scripts/vendor.js

@@ -60806,7 +60806,9 @@ var b = "<none>", c = "<none>";
 return a && a.kind && (b = a.kind), a && a.apiVersion && (c = a.apiVersion), "The API version " + c + " for kind " + b + " is not supported by this server";
 }, t = function(c) {
 var e = [], f = d.AVAILABLE_KINDS_BLACKLIST;
-return _.each(a, function(a) {
+return _.each(_.pick(a, function(a, b) {
+return "openshift" !== b;
+}), function(a) {
 _.each(a.resources.v1, function(a) {
 if (a.namespaced || c) {
 if (a.name.indexOf("/") >= 0 || _.contains(f, a.kind)) return;