Skip to content

Commit 2a61197

Browse files
committed
Match section headings to design specs
1 parent a26e359 commit 2a61197

File tree

4 files changed

+16
-10
lines changed

4 files changed

+16
-10
lines changed

app/styles/_typography.less

+7
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,13 @@ a.subtle-link {
103103
}
104104
}
105105

106+
.section-label {
107+
color: #757575;
108+
font-size: @font-size-base - 3px;
109+
font-weight: normal;
110+
margin-top: @grid-gutter-width / 2;
111+
text-transform: uppercase;
112+
}
106113

107114
/* force a space where it may collapse */
108115
.space-after:after {

app/views/directives/edit-environment-variables.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div ng-repeat="container in $ctrl.containers">
44
<h3>Container {{container.name}}</h3>
55

6-
<h4>Variables</h4>
6+
<h4 class="section-label">Variables</h4>
77
<div ng-if="!$ctrl.canIUpdate || $ctrl.ngReadonly">
88
<span ng-if="!container.env.length">
99
No environment variables set in the {{$ctrl.apiObject.kind | humanizeKind}}
@@ -35,7 +35,7 @@ <h4>Variables</h4>
3535
show-header>
3636
</key-value-editor>
3737

38-
<h4>
38+
<h4 class="section-label">
3939
Environment From
4040
<span class="pficon pficon-help"
4141
aria-hidden="true"

dist/scripts/templates.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6705,7 +6705,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
67056705
"<confirm-on-exit ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" dirty=\"$ctrl.form.$dirty\"></confirm-on-exit>\n" +
67066706
"<div ng-repeat=\"container in $ctrl.containers\">\n" +
67076707
"<h3>Container {{container.name}}</h3>\n" +
6708-
"<h4>Variables</h4>\n" +
6708+
"<h4 class=\"section-label\">Variables</h4>\n" +
67096709
"<div ng-if=\"!$ctrl.canIUpdate || $ctrl.ngReadonly\">\n" +
67106710
"<span ng-if=\"!container.env.length\">\n" +
67116711
"No environment variables set in the {{$ctrl.apiObject.kind | humanizeKind}} template for container {{container.name}}.\n" +
@@ -6715,7 +6715,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
67156715
"</div>\n" +
67166716
"<key-value-editor ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" entries=\"container.env\" key-placeholder=\"Name\" value-placeholder=\"Value\" value-from-selector-options=\"$ctrl.valueFromObjects\" key-validator=\"[A-Za-z_][A-Za-z0-9_]*\" key-validator-error=\"Please enter a valid key.\" key-validator-error-tooltip=\"A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores.\" add-row-link=\"Add Variable\" add-row-with-selectors-link=\"Add Variable from Config Map or Secret\" show-header>\n" +
67176717
"</key-value-editor>\n" +
6718-
"<h4>\n" +
6718+
"<h4 class=\"section-label\">\n" +
67196719
"Environment From\n" +
67206720
"<span class=\"pficon pficon-help\" aria-hidden=\"true\" data-toggle=\"tooltip\" data-original-title=\"Environment From lets you add all key-value pairs from a config map or secret as environment variables.\"></span>\n" +
67216721
"</h4>\n" +

dist/styles/main.css

+5-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)