Skip to content

Commit 3eb8f16

Browse files
committed
Bug 1333162 Improve descriptions for quota scopes
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1333162
1 parent c21f7f6 commit 3eb8f16

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

app/scripts/filters/resources.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1233,10 +1233,10 @@ angular.module('openshiftConsole')
12331233
})
12341234
.filter('scopeDetails', function(sentenceCaseFilter) {
12351235
var scopeMessages = {
1236-
"Terminating": "Matches pods that have an active deadline.",
1237-
"NotTerminating": "Matches pods that do not have an active deadline.",
1238-
"BestEffort": "Matches pods that have best effort quality of service.",
1239-
"NotBestEffort": "Matches pods that do not have best effort quality of service."
1236+
"Terminating": "Affects pods that have an active deadline. These pods usually include builds, deployers, and jobs.",
1237+
"NotTerminating": "Affects pods that do not have an active deadline. These pods usually include your applications.",
1238+
"BestEffort": "Affects pods that do not have resource limits set. These pods have a best effort quality of service.",
1239+
"NotBestEffort": "Affects pods that have at least one resource limit set. These pods do not have a best effort quality of service."
12401240
};
12411241
return function(scope) {
12421242
return scopeMessages[scope] || sentenceCaseFilter(scope);

dist/scripts/scripts.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -13263,10 +13263,10 @@ return a.readinessProbe || a.livenessProbe;
1326313263
};
1326413264
}).filter("scopeDetails", [ "sentenceCaseFilter", function(a) {
1326513265
var b = {
13266-
Terminating:"Matches pods that have an active deadline.",
13267-
NotTerminating:"Matches pods that do not have an active deadline.",
13268-
BestEffort:"Matches pods that have best effort quality of service.",
13269-
NotBestEffort:"Matches pods that do not have best effort quality of service."
13266+
Terminating:"Affects pods that have an active deadline. These pods usually include builds, deployers, and jobs.",
13267+
NotTerminating:"Affects pods that do not have an active deadline. These pods usually include your applications.",
13268+
BestEffort:"Affects pods that do not have resource limits set. These pods have a best effort quality of service.",
13269+
NotBestEffort:"Affects pods that have at least one resource limit set. These pods do not have a best effort quality of service."
1327013270
};
1327113271
return function(c) {
1327213272
return b[c] || a(c);

0 commit comments

Comments
 (0)