Skip to content

Commit 3f779bc

Browse files
author
OpenShift Bot
authored
Merge pull request #1229 from benjaminapetersen/bug-1420247-namespace-in-existing-rolebinding-check
Merged by openshift-bot
2 parents be73cc1 + ac3c075 commit 3f779bc

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

app/scripts/controllers/membership.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ angular
337337
// infer this, but isn't clear at the moment. Will fast-follow PR if
338338
// a good solution is found.
339339
var rolebindingToUpdate = _.find($scope.roleBindings, {roleRef: {name: role.metadata.name}});
340-
if(rolebindingToUpdate && _.some(rolebindingToUpdate.subjects, {name: subjectName})) {
340+
if(rolebindingToUpdate && _.some(rolebindingToUpdate.subjects, subject)) {
341341
showAlert('rolebindingUpdate', 'info', messages.update.subject.exists({
342342
roleName: role.metadata.name,
343343
subjectName: subjectName

dist/scripts/scripts.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -5519,9 +5519,7 @@ roleRef:{
55195519
name:c.metadata.name
55205520
}
55215521
});
5522-
g && _.some(g.subjects, {
5523-
name:a
5524-
}) ? u("rolebindingUpdate", "info", t.update.subject.exists({
5522+
g && _.some(g.subjects, f) ? u("rolebindingUpdate", "info", t.update.subject.exists({
55255523
roleName:c.metadata.name,
55265524
subjectName:a
55275525
})) :g ? z(g, f, e) :y(c, f, e);

0 commit comments

Comments
 (0)