Skip to content

Commit 4aa9a1c

Browse files
committed
Fix bug deleting bindings for service instance
The logic checking if the binding was already deleted was flipped.
1 parent ec0a953 commit 4aa9a1c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: app/scripts/services/serviceInstances.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ angular.module("openshiftConsole")
6060
var resource = APIService.getPreferredVersion('serviceinstancecredentials');
6161
getBindingsIfNecessary(apiObject, bindings).then(function(serviceBindings) {
6262
_.each(serviceBindings, function (binding) {
63-
if (!binding.metadata.deletionTimestamp) {
63+
if (binding.metadata.deletionTimestamp) {
6464
return;
6565
}
6666

Diff for: dist/scripts/scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4315,7 +4315,7 @@ namespace: t.metadata.namespace
43154315
}, u = a.getPreferredVersion("serviceinstancecredentials");
43164316
l(t, n).then(function(t) {
43174317
_.each(t, function(t) {
4318-
t.metadata.deletionTimestamp && i.delete(u, t.metadata.name, r).then(function() {
4318+
t.metadata.deletionTimestamp || i.delete(u, t.metadata.name, r).then(function() {
43194319
c.addNotification({
43204320
type: "success",
43214321
message: "Binding " + t.metadata.name + "' was marked for deletion."

0 commit comments

Comments
 (0)