Skip to content

Commit 4d03d98

Browse files
author
OpenShift Bot
authored
Merge pull request #1156 from spadgett/storage-class-always-visible
Merged by openshift-bot
2 parents ce46f5a + c7290c8 commit 4d03d98

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

app/scripts/directives/oscPersistentVolumeClaim.js

+4
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@ angular.module("openshiftConsole")
8484

8585
DataService.list({group: 'storage.k8s.io', resource: 'storageclasses'}, {}, function(storageClassData) {
8686
var storageClasses = storageClassData.by('metadata.name');
87+
if (_.isEmpty(storageClasses)) {
88+
return;
89+
}
90+
8791
scope.storageClasses = _.sortBy(storageClasses, 'metadata.name');
8892
var annotation = $filter('annotation');
8993
scope.defaultStorageClass = _.find(scope.storageClasses, function(storageClass) {

app/views/directives/osc-persistent-volume-claim.html

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
<ng-form name="persistentVolumeClaimForm">
22
<fieldset ng-disabled="claimDisabled">
3-
<div ng-show="storageClasses | hashSize" class="form-group">
3+
<div ng-if="storageClasses.length" class="form-group">
44
<!--storage class-->
55
<label>Storage Class</label>
66
<div>
77
<ui-select
8-
ng-if="storageClasses"
98
ng-model="claim.storageClass"
109
theme="bootstrap"
1110
search-enabled="true"

dist/scripts/scripts.js

+2
Original file line numberDiff line numberDiff line change
@@ -10264,6 +10264,7 @@ group:"storage.k8s.io",
1026410264
resource:"storageclasses"
1026510265
}, {}, function(b) {
1026610266
var c = b.by("metadata.name");
10267+
if (!_.isEmpty(c)) {
1026710268
e.storageClasses = _.sortBy(c, "metadata.name");
1026810269
var d = a("annotation");
1026910270
if (e.defaultStorageClass = _.find(e.storageClasses, function(a) {
@@ -10280,6 +10281,7 @@ description:"No storage class will be assigned"
1028010281
};
1028110282
e.storageClasses.unshift(f);
1028210283
}
10284+
}
1028310285
}, {
1028410286
errorNotification:!1
1028510287
}), b.list("limitranges", {

dist/scripts/templates.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7816,11 +7816,11 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
78167816
$templateCache.put('views/directives/osc-persistent-volume-claim.html',
78177817
"<ng-form name=\"persistentVolumeClaimForm\">\n" +
78187818
"<fieldset ng-disabled=\"claimDisabled\">\n" +
7819-
"<div ng-show=\"storageClasses | hashSize\" class=\"form-group\">\n" +
7819+
"<div ng-if=\"storageClasses.length\" class=\"form-group\">\n" +
78207820
"\n" +
78217821
"<label>Storage Class</label>\n" +
78227822
"<div>\n" +
7823-
"<ui-select ng-if=\"storageClasses\" ng-model=\"claim.storageClass\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a storage class\" class=\"select-role\">\n" +
7823+
"<ui-select ng-model=\"claim.storageClass\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a storage class\" class=\"select-role\">\n" +
78247824
"<ui-select-match placeholder=\"Select a storage class\">\n" +
78257825
"<span>\n" +
78267826
"{{$select.selected.metadata.name}}\n" +

0 commit comments

Comments
 (0)