Skip to content

Commit 7022250

Browse files
committedDec 9, 2016
Bug 1251870 label value validation is broken
1 parent d7af2d9 commit 7022250

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎app/views/directives/label-editor.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
key-validator-regex="validator.key"
3131
value-placeholder="Value"
3232
value-maxlength="63"
33-
value-validator-regex="validator.val"
33+
value-validator-regex="validator.value"
3434
key-validator-error-tooltip="A valid object label has the form [domain/]name where a name is an alphanumeric (a-z, and 0-9) string,
3535
with a maximum length of 63 characters, with the '-' character allowed anywhere except the first or last
3636
character. A domain is a sequence of names separated by the '.' character with a maximum length of 253 characters."

‎dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6915,7 +6915,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
69156915
"{{helpText}}\n" +
69166916
"</div>\n" +
69176917
"<div ng-show=\"expand\" ng-class=\"{ 'gutter-top': !helpText }\">\n" +
6918-
"<key-value-editor entries=\"labels\" key-placeholder=\"Name\" key-maxlength=\"63\" key-validator-regex=\"validator.key\" value-placeholder=\"Value\" value-maxlength=\"63\" value-validator-regex=\"validator.val\" key-validator-error-tooltip=\"A valid object label has the form [domain/]name where a name is an alphanumeric (a-z, and 0-9) string,\n" +
6918+
"<key-value-editor entries=\"labels\" key-placeholder=\"Name\" key-maxlength=\"63\" key-validator-regex=\"validator.key\" value-placeholder=\"Value\" value-maxlength=\"63\" value-validator-regex=\"validator.value\" key-validator-error-tooltip=\"A valid object label has the form [domain/]name where a name is an alphanumeric (a-z, and 0-9) string,\n" +
69196919
" with a maximum length of 63 characters, with the '-' character allowed anywhere except the first or last\n" +
69206920
" character. A domain is a sequence of names separated by the '.' character with a maximum length of 253 characters.\" value-validator-error-tooltip=\"A valid label value is an alphanumeric (a-z, and 0-9) string, with a maximum length of 63 characters, with the '-'\n" +
69216921
" character allowed anywhere except the first or last character.\" add-row-link=\"Add Label\"></key-value-editor>\n" +

0 commit comments

Comments
 (0)
Please sign in to comment.