Skip to content

Commit 780da67

Browse files
Add titles to roles in dropdown list on membership page
1 parent 293bf56 commit 780da67

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

app/views/membership.html

+13-5
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ <h3>
125125
ng-model="subject.newRole"
126126
theme="bootstrap"
127127
search-enabled="true"
128-
title="Select a new role for {{subjectKind.name}}"
128+
title="Select a new role for {{subject.name}}"
129129
class="select-role"
130130
flex>
131131
<ui-select-match
@@ -134,8 +134,12 @@ <h3>
134134
</ui-select-match>
135135
<ui-select-choices
136136
repeat="role as role in filteredRoles | filter: excludeExistingRoles(subject.roles) | filter: { metadata: { name: $select.search } } track by (role | uid)">
137-
<div ng-bind-html="role.metadata.name | highlight: $select.search"></div>
138-
<div ng-if="role | annotation : 'description'">
137+
<div
138+
ng-bind-html="role.metadata.name | highlight: $select.search"
139+
title="{{role.metadata.name}}"></div>
140+
<div
141+
ng-if="role | annotation : 'description'"
142+
title="{{role.metadata.name}}">
139143
<small>{{role | annotation : 'description'}}</small>
140144
</div>
141145
</ui-select-choices>
@@ -245,8 +249,12 @@ <h3>
245249
</ui-select-match>
246250
<ui-select-choices
247251
repeat="role as role in filteredRoles | filter: { metadata: { name: $select.search } } track by (role | uid)">
248-
<div ng-bind-html="role.metadata.name | highlight: $select.search"></div>
249-
<div ng-if="role | annotation : 'description'">
252+
<div
253+
ng-bind-html="role.metadata.name | highlight: $select.search"
254+
title="{{role.metadata.name}}"></div>
255+
<div
256+
ng-if="role | annotation : 'description'"
257+
title="{{role.metadata.name}}">
250258
<small>{{role | annotation : 'description'}}</small>
251259
</div>
252260
</ui-select-choices>

dist/scripts/templates.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -10725,13 +10725,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1072510725
"</div>\n" +
1072610726
"<div ng-if=\"mode.edit\" class=\"col-add-role\">\n" +
1072710727
"<div row>\n" +
10728-
"<ui-select ng-if=\"filteredRoles.length\" ng-model=\"subject.newRole\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a new role for {{subjectKind.name}}\" class=\"select-role\" flex>\n" +
10728+
"<ui-select ng-if=\"filteredRoles.length\" ng-model=\"subject.newRole\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a new role for {{subject.name}}\" class=\"select-role\" flex>\n" +
1072910729
"<ui-select-match placeholder=\"Select a role\">\n" +
1073010730
"<span ng-bind=\"subject.newRole.metadata.name\"></span>\n" +
1073110731
"</ui-select-match>\n" +
1073210732
"<ui-select-choices repeat=\"role as role in filteredRoles | filter: excludeExistingRoles(subject.roles) | filter: { metadata: { name: $select.search } } track by (role | uid)\">\n" +
10733-
"<div ng-bind-html=\"role.metadata.name | highlight: $select.search\"></div>\n" +
10734-
"<div ng-if=\"role | annotation : 'description'\">\n" +
10733+
"<div ng-bind-html=\"role.metadata.name | highlight: $select.search\" title=\"{{role.metadata.name}}\"></div>\n" +
10734+
"<div ng-if=\"role | annotation : 'description'\" title=\"{{role.metadata.name}}\">\n" +
1073510735
"<small>{{role | annotation : 'description'}}</small>\n" +
1073610736
"</div>\n" +
1073710737
"</ui-select-choices>\n" +
@@ -10783,8 +10783,8 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1078310783
"<span ng-bind=\"newBinding.newRole.metadata.name\"></span>\n" +
1078410784
"</ui-select-match>\n" +
1078510785
"<ui-select-choices repeat=\"role as role in filteredRoles | filter: { metadata: { name: $select.search } } track by (role | uid)\">\n" +
10786-
"<div ng-bind-html=\"role.metadata.name | highlight: $select.search\"></div>\n" +
10787-
"<div ng-if=\"role | annotation : 'description'\">\n" +
10786+
"<div ng-bind-html=\"role.metadata.name | highlight: $select.search\" title=\"{{role.metadata.name}}\"></div>\n" +
10787+
"<div ng-if=\"role | annotation : 'description'\" title=\"{{role.metadata.name}}\">\n" +
1078810788
"<small>{{role | annotation : 'description'}}</small>\n" +
1078910789
"</div>\n" +
1079010790
"</ui-select-choices>\n" +

0 commit comments

Comments
 (0)